Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9220)

Unified Diff: chrome/test/data/extensions/api_test/metrics/test.js

Issue 141393002: Return a NULL histogram pointer on construction error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move some impl to cc Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/metrics/test.js
diff --git a/chrome/test/data/extensions/api_test/metrics/test.js b/chrome/test/data/extensions/api_test/metrics/test.js
index b919fdb9001096ed3ac1b54a030586bf3a52a52a..619a14176027912e9a3716845a25e43861258545 100644
--- a/chrome/test/data/extensions/api_test/metrics/test.js
+++ b/chrome/test/data/extensions/api_test/metrics/test.js
@@ -92,5 +92,50 @@ chrome.test.runTests([
});
},
+ function testBucketSizeChanges() {
+ var linear1 = {
+ 'metricName': 'test.bucketchange.linear',
+ 'type': 'histogram-linear',
+ 'min': 0,
+ 'max': 100,
+ 'buckets': 10
+ };
+ var linear2 = {
+ 'metricName': 'test.bucketchange.linear',
+ 'type': 'histogram-linear',
+ 'min': 0,
+ 'max': 100,
+ 'buckets': 20
+ };
+ var log1 = {
+ 'metricName': 'test.bucketchange.log',
+ 'type': 'histogram-log',
+ 'min': 0,
+ 'max': 100,
+ 'buckets': 10
+ };
+ var log2 = {
+ 'metricName': 'test.bucketchange.log',
+ 'type': 'histogram-log',
+ 'min': 0,
+ 'max': 100,
+ 'buckets': 20
+ };
+
+ chrome.metricsPrivate.recordValue(linear1, 42);
+ // This one should be rejected because the bucket count is different.
+ // We check for sample count == 2 in metrics_apitest.cc
+ chrome.metricsPrivate.recordValue(linear2, 42);
+ chrome.metricsPrivate.recordValue(linear1, 42);
+
+ chrome.metricsPrivate.recordValue(log1, 42);
+ // This one should be rejected because the bucket count is different.
+ // We check for sample count == 2 in metrics_apitest.cc
+ chrome.metricsPrivate.recordValue(log2, 42);
+ chrome.metricsPrivate.recordValue(log1, 42);
+
+ chrome.test.succeed();
+ },
+
]);

Powered by Google App Engine
This is Rietveld 408576698