Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

Issue 141393002: Return a NULL histogram pointer on construction error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, git cl format Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
diff --git a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
index 89d1d9d40e5c39368124f745031273a9f17d352a..168d1a67b97fb01f6d53ea88cac0bc83a492fb97 100644
--- a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
+++ b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
@@ -139,7 +139,10 @@ bool MetricsHistogramHelperFunction::RecordValue(
base::HistogramBase::kUmaTargetedHistogramFlag);
}
- counter->Add(sample);
+ // The histogram can be NULL if it is constructed with bad arguments. Ignore
+ // that data for this API. An error message will be logged.
+ if (counter)
+ counter->Add(sample);
return true;
}
« no previous file with comments | « chrome/browser/extensions/api/metrics_private/metrics_apitest.cc ('k') | chrome/renderer/pepper/pepper_uma_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698