Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1413923005: Fix deoptimization at ForInStatement::BodyId() (Closed)

Created:
5 years, 1 month ago by Jakob Kummerow
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix deoptimization at ForInStatement::BodyId() Full-codegen prepared for the bailout in the wrong place, causing side effects to be replayed when they shouldn't. Crankshaft and Turbofan are in agreement about where the deopt should jump to. TEST=mjsunit/for-in-opt R=jarin@chromium.org BUG=v8:4381 LOG=y Committed: https://crrev.com/cabeb7db3a5be7f802465df2bb1cadb197cc5587 Cr-Commit-Position: refs/heads/master@{#31607}

Patch Set 1 #

Patch Set 2 : moar test cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -9 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/for-in-opt.js View 1 2 chunks +75 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
5 years, 1 month ago (2015-10-27 13:50:54 UTC) #1
Jarin
lgtm
5 years, 1 month ago (2015-10-27 14:42:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413923005/20001
5 years, 1 month ago (2015-10-27 14:42:59 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-27 15:17:07 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 15:17:41 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cabeb7db3a5be7f802465df2bb1cadb197cc5587
Cr-Commit-Position: refs/heads/master@{#31607}

Powered by Google App Engine
This is Rietveld 408576698