Implement cryptographically secure random numbers by using crypto.getRandomValues.

Implement cryptographically secure random numbers by using crypto.getRandomValues.

Closes https://github.com/dart-lang/sdk/issues/24687

R=floitsch@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/b70109683bdf74676a9a3044ab485e756a492530

[Lasse Reichstein Nielsen, 2015-10-22 14:05:03]

lrn@google.com changed reviewers:
+ sigmund@google.com

[Lasse Reichstein Nielsen, 2015-10-22 14:05:03]

Test runs on drt and mocked in d8. Haven't checked the remaining browsers yet.

[kevmoo, 2015-10-22 15:14:20]

Description was changed from

==========
Implement cryptographically secure random numbers by using
crypto.getRandomValues.
==========

to

==========
Implement cryptographically secure random numbers by using
crypto.getRandomValues.

Closes https://github.com/dart-lang/sdk/issues/24687
==========

[kevmoo, 2015-10-22 15:15:03]

On 2015/10/22 14:05:03, Lasse Reichstein Nielsen wrote:
> Test runs on drt and mocked in d8. Haven't checked the remaining browsers yet.

Woo hoo!

[kevmoo, 2015-10-22 15:27:16]

On 2015/10/22 15:15:03, kevmoo wrote:
> On 2015/10/22 14:05:03, Lasse Reichstein Nielsen wrote:
> > Test runs on drt and mocked in d8. Haven't checked the remaining browsers
yet.
> 
> Woo hoo!

I was just going to return a new Random w/ the seed set off getRandomValue – but
your way seems fancier. :-D

[floitsch, 2015-10-22 19:34:05]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-10-22 19:34:05]

LGTM.

https://codereview.chromium.org/1413923004/diff/20001/sdk/lib/_internal/js_ru...
File sdk/lib/_internal/js_runtime/lib/math_patch.dart (right):

https://codereview.chromium.org/1413923004/diff/20001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/math_patch.dart:309: int result = random % max;
.remainder

[Siggi Cherem (dart-lang), 2015-10-22 19:45:11]

lgtm!

[Lasse Reichstein Nielsen, 2015-10-23 09:15:25]

Committed patchset #4 (id:60001) manually as
b70109683bdf74676a9a3044ab485e756a492530 (presubmit successful).

[Lasse Reichstein Nielsen, 2015-10-23 10:53:00]

https://codereview.chromium.org/1413923004/diff/20001/sdk/lib/_internal/js_ru...
File sdk/lib/_internal/js_runtime/lib/math_patch.dart (right):

https://codereview.chromium.org/1413923004/diff/20001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/math_patch.dart:248: final _jsGetRandomValues;
I'm not actually using this, so I'll remove it.

https://codereview.chromium.org/1413923004/diff/20001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/math_patch.dart:309: int result = random % max;
I assume this is a dart2js preference because the result should be the same.