Issue 1413923003: Remove uses of DartObjectImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413923003: Remove uses of DartObjectImpl (Closed)

Created:
5 years, 2 months ago by vsm

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove uses of DartObjectImpl Note: the changes to .txt files are due to unrelated analyzer strong mode fixes. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/b183fe26c6970a90e4f306aca34998236ae2428b

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -23 lines)			Patch
M	lib/src/codegen/js_codegen.dart	View	4 chunks	+8 lines, -6 lines	0 comments	Download
M	lib/src/codegen/side_effect_analysis.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/utils.dart	View	3 chunks	+7 lines, -12 lines	0 comments	Download
M	test/codegen/expect/collection/equality.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/codegen/expect/js_test.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

vsm

5 years, 2 months ago (2015-10-19 20:00:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b183fe26c6970a90e4f306aca34998236ae2428b (presubmit successful).