Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1413913002: Switch on unit test regarding -Infinity and TypedArrays (Closed)

Created:
5 years, 2 months ago by Michael Hablich
Modified:
5 years, 2 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Switch on unit test regarding -Infinity and TypedArrays Should already work according to issue. BUG=chromium:424619 LOG=N R=adamk@chromium.org, littledan@chromium.org Committed: https://crrev.com/fb8a97eed9c30e171ced207381b14b41da1dc35f Cr-Commit-Position: refs/heads/master@{#31379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M test/mjsunit/es6/typedarray.js View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Hablich
PTAL
5 years, 2 months ago (2015-10-19 12:12:48 UTC) #1
adamk
lgtm if this passes tests, but I can't see the attached bug
5 years, 2 months ago (2015-10-19 13:29:57 UTC) #4
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-10-19 14:25:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413913002/1
5 years, 2 months ago (2015-10-19 14:25:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 14:26:32 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 14:26:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb8a97eed9c30e171ced207381b14b41da1dc35f
Cr-Commit-Position: refs/heads/master@{#31379}

Powered by Google App Engine
This is Rietveld 408576698