Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: runtime/bin/socket_macos.cc

Issue 14139032: Fix broken Mac OS socket code (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/socket_linux.cc ('k') | runtime/bin/socket_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 #if defined(TARGET_OS_MACOS) 6 #if defined(TARGET_OS_MACOS)
7 7
8 #include <errno.h> // NOLINT 8 #include <errno.h> // NOLINT
9 #include <stdio.h> // NOLINT 9 #include <stdio.h> // NOLINT
10 #include <stdlib.h> // NOLINT 10 #include <stdlib.h> // NOLINT
(...skipping 24 matching lines...) Expand all
35 35
36 bool Socket::Initialize() { 36 bool Socket::Initialize() {
37 // Nothing to do on Mac OS. 37 // Nothing to do on Mac OS.
38 return true; 38 return true;
39 } 39 }
40 40
41 41
42 intptr_t Socket::CreateConnect(RawAddr addr, const intptr_t port) { 42 intptr_t Socket::CreateConnect(RawAddr addr, const intptr_t port) {
43 intptr_t fd; 43 intptr_t fd;
44 44
45 fd = TEMP_FAILURE_RETRY(socket(addr.ss_family, SOCK_STREAM, 0)); 45 fd = TEMP_FAILURE_RETRY(socket(addr.ss.ss_family, SOCK_STREAM, 0));
46 if (fd < 0) { 46 if (fd < 0) {
47 Log::PrintErr("Error CreateConnect: %s\n", strerror(errno)); 47 Log::PrintErr("Error CreateConnect: %s\n", strerror(errno));
48 return -1; 48 return -1;
49 } 49 }
50 50
51 FDUtils::SetCloseOnExec(fd); 51 FDUtils::SetCloseOnExec(fd);
52 Socket::SetNonBlocking(fd); 52 Socket::SetNonBlocking(fd);
53 53
54 SocketAddress::SetAddrPort(&addr, port); 54 SocketAddress::SetAddrPort(&addr, port);
55 intptr_t result = TEMP_FAILURE_RETRY( 55 intptr_t result = TEMP_FAILURE_RETRY(
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 RawAddr raw; 115 RawAddr raw;
116 socklen_t size = sizeof(raw); 116 socklen_t size = sizeof(raw);
117 if (TEMP_FAILURE_RETRY( 117 if (TEMP_FAILURE_RETRY(
118 getpeername(fd, 118 getpeername(fd,
119 &raw.addr, 119 &raw.addr,
120 &size))) { 120 &size))) {
121 Log::PrintErr("Error getpeername: %s\n", strerror(errno)); 121 Log::PrintErr("Error getpeername: %s\n", strerror(errno));
122 return false; 122 return false;
123 } 123 }
124 const void* src; 124 const void* src;
125 if (raw.ss_family == AF_INET6) { 125 if (raw.ss.ss_family == AF_INET6) {
126 src = reinterpret_cast<const void*>(&raw.in6.sin6_addr); 126 src = reinterpret_cast<const void*>(&raw.in6.sin6_addr);
127 } else { 127 } else {
128 src = reinterpret_cast<const void*>(&raw.in.sin_addr); 128 src = reinterpret_cast<const void*>(&raw.in.sin_addr);
129 } 129 }
130 if (inet_ntop(raw.ss_family, 130 if (inet_ntop(raw.ss.ss_family,
131 src, 131 src,
132 host, 132 host,
133 INET_ADDRSTRLEN) == NULL) { 133 INET_ADDRSTRLEN) == NULL) {
134 Log::PrintErr("Error inet_ntop: %s\n", strerror(errno)); 134 Log::PrintErr("Error inet_ntop: %s\n", strerror(errno));
135 return false; 135 return false;
136 } 136 }
137 *port = SocketAddress::GetAddrPort(&raw); 137 *port = SocketAddress::GetAddrPort(&raw);
138 return true; 138 return true;
139 } 139 }
140 140
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 freeaddrinfo(info); 200 freeaddrinfo(info);
201 return addresses; 201 return addresses;
202 } 202 }
203 203
204 204
205 intptr_t ServerSocket::CreateBindListen(RawAddr addr, 205 intptr_t ServerSocket::CreateBindListen(RawAddr addr,
206 intptr_t port, 206 intptr_t port,
207 intptr_t backlog) { 207 intptr_t backlog) {
208 intptr_t fd; 208 intptr_t fd;
209 209
210 fd = TEMP_FAILURE_RETRY(socket(addr.ss_family, SOCK_STREAM, 0)); 210 fd = TEMP_FAILURE_RETRY(socket(addr.ss.ss_family, SOCK_STREAM, 0));
211 if (fd < 0) return -1; 211 if (fd < 0) return -1;
212 212
213 FDUtils::SetCloseOnExec(fd); 213 FDUtils::SetCloseOnExec(fd);
214 214
215 int optval = 1; 215 int optval = 1;
216 VOID_TEMP_FAILURE_RETRY( 216 VOID_TEMP_FAILURE_RETRY(
217 setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &optval, sizeof(optval))); 217 setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &optval, sizeof(optval)));
218 218
219 if (addr.ss_family == AF_INET6) { 219 if (addr.ss.ss_family == AF_INET6) {
220 optval = 0; 220 optval = 0;
221 VOID_TEMP_FAILURE_RETRY( 221 VOID_TEMP_FAILURE_RETRY(
222 setsockopt(fd, IPPROTO_IPV6, IPV6_V6ONLY, &optval, sizeof(optval))); 222 setsockopt(fd, IPPROTO_IPV6, IPV6_V6ONLY, &optval, sizeof(optval)));
223 } 223 }
224 224
225 SocketAddress::SetAddrPort(&addr, port); 225 SocketAddress::SetAddrPort(&addr, port);
226 if (TEMP_FAILURE_RETRY( 226 if (TEMP_FAILURE_RETRY(
227 bind(fd, 227 bind(fd,
228 &addr.addr, 228 &addr.addr,
229 SocketAddress::GetAddrLength(addr))) < 0) { 229 SocketAddress::GetAddrLength(addr))) < 0) {
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 bool Socket::SetNoDelay(intptr_t fd, bool enabled) { 286 bool Socket::SetNoDelay(intptr_t fd, bool enabled) {
287 int on = enabled ? 1 : 0; 287 int on = enabled ? 1 : 0;
288 return TEMP_FAILURE_RETRY(setsockopt(fd, 288 return TEMP_FAILURE_RETRY(setsockopt(fd,
289 IPPROTO_TCP, 289 IPPROTO_TCP,
290 TCP_NODELAY, 290 TCP_NODELAY,
291 reinterpret_cast<char *>(&on), 291 reinterpret_cast<char *>(&on),
292 sizeof(on))) == 0; 292 sizeof(on))) == 0;
293 } 293 }
294 294
295 #endif // defined(TARGET_OS_MACOS) 295 #endif // defined(TARGET_OS_MACOS)
OLDNEW
« no previous file with comments | « runtime/bin/socket_linux.cc ('k') | runtime/bin/socket_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698