Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: ios/chrome/browser/favicon/ios_chrome_large_icon_cache_factory.h

Issue 1413903008: Add LargeIconCache and LargeIconServiceFactory for iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits for unit test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/favicon/ios_chrome_large_icon_cache_factory.h
diff --git a/ios/chrome/browser/dom_distiller/dom_distiller_service_factory.h b/ios/chrome/browser/favicon/ios_chrome_large_icon_cache_factory.h
similarity index 51%
copy from ios/chrome/browser/dom_distiller/dom_distiller_service_factory.h
copy to ios/chrome/browser/favicon/ios_chrome_large_icon_cache_factory.h
index 80e2294e44f52989fe027faaaff3c98d4f860dc4..6a20527c2af4a632fa4627beee623a196d961e24 100644
--- a/ios/chrome/browser/dom_distiller/dom_distiller_service_factory.h
+++ b/ios/chrome/browser/favicon/ios_chrome_large_icon_cache_factory.h
@@ -2,39 +2,39 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef IOS_CHROME_BROWSER_DOM_DISTILLER_DOM_DISTILLER_SERVICE_FACTORY_H_
-#define IOS_CHROME_BROWSER_DOM_DISTILLER_DOM_DISTILLER_SERVICE_FACTORY_H_
+#ifndef IOS_CHROME_BROWSER_FAVICON_IOS_CHROME_LARGE_ICON_CACHE_FACTORY_H_
+#define IOS_CHROME_BROWSER_FAVICON_IOS_CHROME_LARGE_ICON_CACHE_FACTORY_H_
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "components/keyed_service/ios/browser_state_keyed_service_factory.h"
+class KeyedService;
+class LargeIconCache;
+
namespace base {
template <typename T>
struct DefaultSingletonTraits;
-} // namespace base
-
-namespace dom_distiller {
-class DomDistillerService;
}
namespace ios {
class ChromeBrowserState;
}
-namespace dom_distiller {
-
-class DomDistillerServiceFactory : public BrowserStateKeyedServiceFactory {
+// Singleton that owns all LargeIconCaches and associates them with
+// ChromeBrowserState.
+class IOSChromeLargeIconCacheFactory : public BrowserStateKeyedServiceFactory {
public:
- static DomDistillerServiceFactory* GetInstance();
- static DomDistillerService* GetForBrowserState(
+ static LargeIconCache* GetForBrowserState(
ios::ChromeBrowserState* browser_state);
+ static IOSChromeLargeIconCacheFactory* GetInstance();
+
private:
- friend struct base::DefaultSingletonTraits<DomDistillerServiceFactory>;
+ friend struct base::DefaultSingletonTraits<IOSChromeLargeIconCacheFactory>;
- DomDistillerServiceFactory();
- ~DomDistillerServiceFactory() override;
+ IOSChromeLargeIconCacheFactory();
+ ~IOSChromeLargeIconCacheFactory() override;
// BrowserStateKeyedServiceFactory implementation.
scoped_ptr<KeyedService> BuildServiceInstanceFor(
@@ -42,9 +42,7 @@ class DomDistillerServiceFactory : public BrowserStateKeyedServiceFactory {
web::BrowserState* GetBrowserStateToUse(
web::BrowserState* context) const override;
- DISALLOW_COPY(DomDistillerServiceFactory);
+ DISALLOW_COPY_AND_ASSIGN(IOSChromeLargeIconCacheFactory);
};
-} // namespace dom_distiller
-
-#endif // IOS_CHROME_BROWSER_DOM_DISTILLER_DOM_DISTILLER_SERVICE_FACTORY_H_
+#endif // IOS_CHROME_BROWSER_FAVICON_IOS_CHROME_LARGE_ICON_CACHE_FACTORY_H_

Powered by Google App Engine
This is Rietveld 408576698