Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: ios/chrome/browser/favicon/large_icon_cache.cc

Issue 1413903008: Add LargeIconCache and LargeIconServiceFactory for iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: broken sort Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/favicon/large_icon_cache.cc
diff --git a/ios/chrome/browser/favicon/large_icon_cache.cc b/ios/chrome/browser/favicon/large_icon_cache.cc
new file mode 100644
index 0000000000000000000000000000000000000000..27db28ff4e3f8231d5b8a24f2a1424087fe20eba
--- /dev/null
+++ b/ios/chrome/browser/favicon/large_icon_cache.cc
@@ -0,0 +1,61 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ios/chrome/browser/favicon/large_icon_cache.h"
+
+#include "components/favicon_base/fallback_icon_style.h"
+#include "components/favicon_base/favicon_types.h"
+#include "url/gurl.h"
+
+namespace {
+
+const int kMaxCacheSize = 12;
+
+// Cache of LargeIconResult.
sdefresne 2015/10/30 17:20:14 nit: what is this comment doing here? Remove.
justincohen 2015/10/30 19:43:24 Done.
+
+} // namespace
+
+struct LargeIconCacheEntry {
+ LargeIconCacheEntry() {}
+ ~LargeIconCacheEntry() {}
+
+ scoped_ptr<favicon_base::LargeIconResult> result;
+};
+
+LargeIconCache::LargeIconCache() : cache_(kMaxCacheSize) {}
+
+LargeIconCache::~LargeIconCache() {}
+
+void LargeIconCache::SetCachedResult(
+ const GURL& url,
+ const favicon_base::LargeIconResult& result) {
+ LargeIconCacheEntry* entry = new LargeIconCacheEntry;
+ entry->result = CloneLargeIconResult(result);
+ cache_.Put(url, entry);
+}
+
+scoped_ptr<favicon_base::LargeIconResult> LargeIconCache::GetCachedResult(
+ const GURL& url) {
+ base::OwningMRUCache<GURL, LargeIconCacheEntry*>::iterator iter =
sdefresne 2015/10/30 17:20:14 nit: you could have used "auto iter = cache_.Get(u
justincohen 2015/10/30 19:43:24 Done.
+ cache_.Get(url);
+ if (iter != cache_.end()) {
+ DCHECK(iter->second->result);
+ return CloneLargeIconResult(*iter->second->result.get());
+ }
+
+ return scoped_ptr<favicon_base::LargeIconResult>();
+}
+
+scoped_ptr<favicon_base::LargeIconResult> LargeIconCache::CloneLargeIconResult(
+ const favicon_base::LargeIconResult& large_icon_result) {
+ scoped_ptr<favicon_base::LargeIconResult> clone;
+ if (large_icon_result.bitmap.is_valid()) {
+ clone.reset(new favicon_base::LargeIconResult(large_icon_result.bitmap));
+ } else {
+ clone.reset(
+ new favicon_base::LargeIconResult(new favicon_base::FallbackIconStyle(
+ *large_icon_result.fallback_icon_style.get())));
+ }
+ return clone.Pass();
+}

Powered by Google App Engine
This is Rietveld 408576698