Issue 14139029: Fix a couple of style nits:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14139029: Fix a couple of style nits: (Closed)

Created:
7 years, 8 months ago by sadrul

Modified:
7 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright+watch_chromium.org, yusukes+watch_chromium.org, derat+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix a couple of style nits: 1. Move dtor of a ref-counted class in private to fix clang style error during build. 2. Forward declare XEvent in x11_util.h BUG=none R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197023

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	base/message_pump_linux.h	View		2 chunks	+1 line, -1 line	0 comments	Download
	M	ui/base/x/x11_util.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

sadrul

7 years, 7 months ago (2013-04-29 13:37:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r197023 (presubmit successful).