New blobstoragecontext for use in the main browser process, not plugged in yet.

webkit/base/data_element.h

Index: webkit/base/data_element.h
===================================================================
--- webkit/base/data_element.h	(revision 194203)
+++ webkit/base/data_element.h	(working copy)
@@ -34,13 +34,26 @@
   Type type() const { return type_; }
   const char* bytes() const { return bytes_ ? bytes_ : &buf_[0]; }
   const base::FilePath& path() const { return path_; }
-  const GURL& url() const { return url_; }
+  const GURL& filesystem_url() const { return filesystem_url_; }
+
+  // TODO(michaeln): fully switch to using string uuids for blob identifiers.
+  // Note: Identifying blobs by url is being deprecated, but while transitioning
+  // there's a little of both going on in the project.
+  const std::string& blob_uuid() const { return blob_uuid_; }
+  const GURL& blob_url() const { return blob_url_; }
   uint64 offset() const { return offset_; }
   uint64 length() const { return length_; }
   const base::Time& expected_modification_time() const {
     return expected_modification_time_;
   }
 
+  // TODO(michaeln): fixup callers to use filesytem_url() and blob_uuid().
+  const GURL& url() const {
+    if (type_ == TYPE_FILE_FILESYSTEM)
+      return filesystem_url_;
+    return blob_url_;
+  }
+
   // Sets TYPE_BYTES data. This copies the given data into the element.
   void SetToBytes(const char* bytes, int bytes_len) {
     type_ = TYPE_BYTES;
@@ -65,6 +78,9 @@
   void SetToBlobUrl(const GURL& blob_url) {
     SetToBlobUrlRange(blob_url, 0, kuint64max);
   }
+  void SetToBlob(const std::string& uuid) {
+    SetToBlobRange(uuid, 0, kuint64max);
+  }
 
   // Sets TYPE_FILE data with range.
   void SetToFilePathRange(const base::FilePath& path,
@@ -74,6 +90,8 @@
   // Sets TYPE_BLOB data with range.
   void SetToBlobUrlRange(const GURL& blob_url,
                          uint64 offset, uint64 length);
+  void SetToBlobRange(const std::string& blob_uuid,
+                      uint64 offset, uint64 length);
 
   // Sets TYPE_FILE_FILESYSTEM with range.
   void SetToFileSystemUrlRange(const GURL& filesystem_url,
@@ -85,7 +103,9 @@
   std::vector<char> buf_;  // For TYPE_BYTES.
   const char* bytes_;  // For TYPE_BYTES.
   base::FilePath path_;  // For TYPE_FILE.
-  GURL url_;  // For TYPE_BLOB or TYPE_FILE_FILESYSTEM.
+  GURL filesystem_url_;  // For TYPE_FILE_FILESYSTEM.
+  GURL blob_url_;

[ericu, 2013/04/18 02:01:58]

I don't see any reason that you need 2 GURL members; they can still share space
until you stop using url_ for blobs.

[michaeln, 2013/04/23 21:11:10]

true, not strictly needed, but i think makes removing the dead code easier later
and lends greater clarity now... at least that's the idea... i don't feel
strongly but i think the extra storage for the empty GURL is worth it for those
benefits mentioned

+  std::string blob_uuid_;
   uint64 offset_;
   uint64 length_;
   base::Time expected_modification_time_;
@@ -104,8 +124,10 @@
       return a.path() == b.path() &&
              a.expected_modification_time() == b.expected_modification_time();
     case DataElement::TYPE_BLOB:
+      return a.blob_uuid().empty() ? (a.blob_url() == b.blob_url())
+                                   : (a.blob_uuid() == b.blob_uuid());
     case DataElement::TYPE_FILE_FILESYSTEM:
-      return a.url() == b.url();
+      return a.filesystem_url() == b.filesystem_url();
     case DataElement::TYPE_UNKNOWN:
       NOTREACHED();
       return false;