Issue 14139020: Add OWNERS to git-hooks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14139020: Add OWNERS to git-hooks. (Closed)

Created:
7 years, 8 months ago by szager1

Modified:
7 years, 8 months ago

Reviewers:
cmp, cmp_google

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add OWNERS to git-hooks. Since this folder contains arbitrary code to be run on client hosts, it probably ought to have an OWNERS file. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194455

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add 'set noparent' #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	A	build/git-hooks/OWNERS	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cmp_google

lgtm with change https://codereview.chromium.org/14139020/diff/1/build/git-hooks/OWNERS File build/git-hooks/OWNERS (right): https://codereview.chromium.org/14139020/diff/1/build/git-hooks/OWNERS#newcode1 build/git-hooks/OWNERS:1: szager@chromium.org Please insert 'set noparent' before ...

7 years, 8 months ago (2013-04-16 21:12:10 UTC) #2

szager1

Committed patchset #2 manually as r194455 (presubmit successful).

7 years, 8 months ago (2013-04-16 21:16:58 UTC) #3

szager1

7 years, 8 months ago (2013-04-16 21:18:05 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14139020/diff/1/build/git-hooks/OWNERS
File build/git-hooks/OWNERS (right):

https://codereview.chromium.org/14139020/diff/1/build/git-hooks/OWNERS#newcode1
build/git-hooks/OWNERS:1: szager@chromium.org
On 2013/04/16 21:12:10, cmp (DO NOT USE) wrote:
> Please insert 'set noparent' before line 1.

Done.

Expand Messages | Collapse Messages