chrome/browser/ui/views/message_center/web_notification_tray_win.cc - Issue 14139014: Reposition toasts to align the closed one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/message_center/web_notification_tray_win.cc

Issue 14139014: Reposition toasts to align the closed one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/system/web_notification/web_notification_tray.cc ('k') | ui/message_center/message_center.gyp » ('j') | ui/message_center/views/message_popup_collection.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/message_center/web_notification_tray_win.cc

diff --git a/chrome/browser/ui/views/message_center/web_notification_tray_win.cc b/chrome/browser/ui/views/message_center/web_notification_tray_win.cc

index f6974be6efadcdfc2d2ac61878a043f5f0b7d02d..0db887f058a9cf26ed9f09828e712735ce80b3d6 100644

--- a/chrome/browser/ui/views/message_center/web_notification_tray_win.cc

+++ b/chrome/browser/ui/views/message_center/web_notification_tray_win.cc

@@ -169,8 +169,10 @@ void WebNotificationTrayWin::UpdateMessageCenter() {

}

void WebNotificationTrayWin::UpdatePopups() {

- if (popup_collection_.get())

- popup_collection_->UpdatePopups();

+ // |popup_collection_| receives notification add/remove events and updates

+ // itself, so this method doesn't need to do anything.

+ // TODO(mukai): remove this method (currently this is used by

+ // non-rich-notifications in ChromeOS).

};

void WebNotificationTrayWin::OnMessageCenterTrayChanged() {