Reposition toasts to align the closed one.

Reposition toasts to align the closed one.


BUG=224089
TEST=manually && new test passed
TBR=stevenjb@chromium.org,dewittj@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194036

[Jun Mukai, 2013-04-11 18:11:38]

This CL depends on the refactoring CL.

[Jun Mukai, 2013-04-11 21:39:24]

Charles, can you take time to review this? I'm afraid that Justin is not able to
review today (and tomorrow?)

[dharcourt, 2013-04-11 22:44:56]

On 2013/04/11 21:39:24, Jun Mukai wrote:
> Charles, can you take time to review this? I'm afraid that Justin is not able
to
> review today (and tomorrow?)

I can later today but I'm working on a P0 right now (for which you'll get a
review request quite shortly :-).

[dharcourt, 2013-04-12 09:05:37]

Apart from the question below, LGTM.

If the question has an answer that doesn't require a code change, please feel
free to commit. Otherwise depending on the risk of the change you may want me to
review it before the commit or have it TBR.

This is a much simpler implementation than I expected, very cool!

https://codereview.chromium.org/14139014/diff/6001/ui/message_center/views/me...
File ui/message_center/views/message_popup_collection.cc (right):

https://codereview.chromium.org/14139014/diff/6001/ui/message_center/views/me...
ui/message_center/views/message_popup_collection.cc:105:
base::Unretained(message_center_), id_, false));
Won't this remove the notification from the notification center as well as
dismissing the toast? I thought the timer was just to dismiss the notification's
toast. What am I missing?

[Jun Mukai, 2013-04-12 21:20:54]

https://codereview.chromium.org/14139014/diff/6001/ui/message_center/views/me...
File ui/message_center/views/message_popup_collection.cc (right):

https://codereview.chromium.org/14139014/diff/6001/ui/message_center/views/me...
ui/message_center/views/message_popup_collection.cc:105:
base::Unretained(message_center_), id_, false));
On 2013/04/12 09:05:38, dharcourt wrote:
> Won't this remove the notification from the notification center as well as
> dismissing the toast? I thought the timer was just to dismiss the
notification's
> toast. What am I missing?

Ugha, you're right. I'm doing a bad thing.
reverting the change around timers. Sigh...

[Jun Mukai, 2013-04-12 23:00:36]

On 2013/04/12 21:20:54, Jun Mukai wrote:
>
https://codereview.chromium.org/14139014/diff/6001/ui/message_center/views/me...
> File ui/message_center/views/message_popup_collection.cc (right):
> 
>
https://codereview.chromium.org/14139014/diff/6001/ui/message_center/views/me...
> ui/message_center/views/message_popup_collection.cc:105:
> base::Unretained(message_center_), id_, false));
> On 2013/04/12 09:05:38, dharcourt wrote:
> > Won't this remove the notification from the notification center as well as
> > dismissing the toast? I thought the timer was just to dismiss the
> notification's
> > toast. What am I missing?
> 
> Ugha, you're right. I'm doing a bad thing.
> reverting the change around timers. Sigh...

looks green. I'll dcommit considering the current timeframe...

[Jun Mukai, 2013-04-12 23:02:41]

notice: adding TBRs
stevenjb: ash/system/web_notification
dewittj: c/b/ui/views/message_center

simply removed unused method invocations there.

[Jun Mukai, 2013-04-12 23:03:13]

Committed patchset #3 manually as r194036 (presubmit successful).