cc/input/top_controls_state_list.h - Issue 14139013: Hide location bar on Javascript-initiated scroll.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/input/top_controls_state_list.h

Issue 14139013: Hide location bar on Javascript-initiated scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge ShowTopControls into UpdateTopControlsState, use new TopControlsState enum in plumbing, gener… Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CC_INPUT_TOP_CONTROLS_STATE_LIST_H_

	6 #define CC_INPUT_TOP_CONTROLS_STATE_LIST_H_

	7

	8 #ifndef DEFINE_TOP_CONTROLS_STATE

	9 #error "DEFINE_TOP_CONTROLS_STATE should be defined before including this file"

	10 #endif

	11

	12 // These values are defined with macros so that a Java class can be generated
	aelias_OOO_until_Jul13 2013/05/02 18:44:23 I understand the problem you're addressing here bu I understand the problem you're addressing here but it's not really a concern of CC, and AFAIK this is not an accepted pattern in Chromium code. Please define the enum normally and have matching constants on the Java side, and add some comments warning about the other class that should be modified in sync. (This enum shouldn't often change anyway.) Michael van Ouwerkerk 2013/05/08 16:21:15 Well, there is precedent in net/ chrome/ and conte Well, there is precedent in net/ chrome/ and content/: net/android/java/NetError.template chrome/android/java/ToolbarModelSecurityLevel.template content/public/android/java/src/org/chromium/content/common/ResultCodes.template Marcus Bulach tells me this is the way forward, and we expect to use this pattern more in the future. Because of this, I'd prefer to keep this part as is. On 2013/05/02 18:44:23, aelias wrote: Show quoted text > I understand the problem you're addressing here but it's not really a concern of > CC, and AFAIK this is not an accepted pattern in Chromium code. Please define > the enum normally and have matching constants on the Java side, and add some > comments warning about the other class that should be modified in sync. (This > enum shouldn't often change anyway.)
	13 // for them.

	14 DEFINE_TOP_CONTROLS_STATE(SHOWN, 1)

	15 DEFINE_TOP_CONTROLS_STATE(HIDDEN, 2)

	16 DEFINE_TOP_CONTROLS_STATE(BOTH, 3)

	17

	18 #endif // CC_INPUT_TOP_CONTROLS_STATE_LIST_H_

	19

OLD	NEW

« cc/input/top_controls_manager.cc ('K') | « cc/input/top_controls_state.h ('k') | cc/trees/layer_tree_host.h » ('j') | content/common/view_messages.h » ('J')