Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Unified Diff: tools/test.dart

Issue 14139011: Print the failure summary by default (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/test.dart
diff --git a/tools/test.dart b/tools/test.dart
index 218f9964ecb331d8210da6825a37ea847abd936b..01df1c493937d4b681969b68780100a31ddba5a7 100755
--- a/tools/test.dart
+++ b/tools/test.dart
@@ -80,6 +80,8 @@ void testConfigurations(List<Map> configurations) {
Map<String, RegExp> selectors = firstConf['selectors'];
var maxProcesses = firstConf['tasks'];
var progressIndicator = firstConf['progress'];
+ // TODO(kustermann): Remove this option once the buildbots don't use it
+ // anymore.
var failureSummary = firstConf['failure-summary'];
BuildbotProgressIndicator.stepName = firstConf['step_name'];
var verbose = firstConf['verbose'];
@@ -195,9 +197,8 @@ void testConfigurations(List<Map> configurations) {
eventListener.add(new FlakyLogWriter());
if (printFailures) {
// The buildbot has it's own failure summary since it needs to wrap it
- // into'@@@'-annotated sections.
- var printFaiureSummary =
- failureSummary && progressIndicator != 'buildbot';
+ // into '@@@'-annotated sections.
+ var printFaiureSummary = progressIndicator != 'buildbot';
Bill Hesse 2013/04/11 17:01:57 I would call this variable printFailureSummary, ra
kustermann 2013/04/12 15:08:52 Done.
eventListener.add(new TestFailurePrinter(printFaiureSummary, formatter));
}
eventListener.add(new ProgressIndicator.fromName(progressIndicator,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698