Move v8_use_external_startup_data out of //build/config:feature_flags.

chrome/plugin/BUILD.gn

Index: chrome/plugin/BUILD.gn
diff --git a/chrome/plugin/BUILD.gn b/chrome/plugin/BUILD.gn
index 1da688a0741b86e45b2e3056bd13812ab31a3b1f..9ab14b5765b106f23576d1adbc143356b55fe2bc 100644
--- a/chrome/plugin/BUILD.gn
+++ b/chrome/plugin/BUILD.gn
@@ -2,6 +2,8 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//build_overrides/v8.gni")
+
 static_library("plugin") {
   sources = [
     "chrome_content_plugin_client.cc",
@@ -9,6 +11,9 @@ static_library("plugin") {
   ]
 
   configs += [ "//build/config/compiler:wexit_time_destructors" ]
+  if (v8_use_external_startup_data) {
+    configs += [ "//v8:external_startup_data" ]

[brettw, 2015/10/20 02:44:41]

Did you consider making the config check the flag value and set the define or
not according to that? Then you can avoid the conditions and imports in each of
these files.

[Dirk Pranke, 2015/10/20 03:00:16]

I did, yes. 

In some cases (e.g., net) we have to do additional logic based on the flag as
well, so I thought it might be better to always make everyone check the flag to
be consistent.

I can make the config check the flag instead if you think that would be better
(or, at least, work up a patch that does that for you to compare the two).

+  }
 
   deps = [
     "//base",