Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: gin/BUILD.gn

Issue 1413893003: Move v8_use_external_startup_data out of //build/config:feature_flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_v8_module_args
Patch Set: make config be always defined Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/test/BUILD.gn ('k') | media/blink/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build_overrides/v8.gni") 5 import("//build_overrides/v8.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 7
8 component("gin") { 8 component("gin") {
9 sources = [ 9 sources = [
10 "arguments.cc", 10 "arguments.cc",
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 ] 82 ]
83 deps = [ 83 deps = [
84 "//base/third_party/dynamic_annotations", 84 "//base/third_party/dynamic_annotations",
85 ] 85 ]
86 if (v8_use_external_startup_data && is_win) { 86 if (v8_use_external_startup_data && is_win) {
87 public_deps += [ ":gin_v8_snapshot_fingerprint" ] 87 public_deps += [ ":gin_v8_snapshot_fingerprint" ]
88 deps += [ "//crypto:crypto" ] 88 deps += [ "//crypto:crypto" ]
89 sources += [ "$target_gen_dir/v8_snapshot_fingerprint.cc" ] 89 sources += [ "$target_gen_dir/v8_snapshot_fingerprint.cc" ]
90 defines += [ "V8_VERIFY_EXTERNAL_STARTUP_DATA" ] 90 defines += [ "V8_VERIFY_EXTERNAL_STARTUP_DATA" ]
91 } 91 }
92
93 configs += [ "//v8:external_startup_data" ]
92 } 94 }
93 95
94 if (v8_use_external_startup_data) { 96 if (v8_use_external_startup_data) {
95 action("gin_v8_snapshot_fingerprint") { 97 action("gin_v8_snapshot_fingerprint") {
96 script = "//gin/fingerprint/fingerprint_v8_snapshot.py" 98 script = "//gin/fingerprint/fingerprint_v8_snapshot.py"
97 99
98 snapshot_file = "$root_build_dir/snapshot_blob.bin" 100 snapshot_file = "$root_build_dir/snapshot_blob.bin"
99 natives_file = "$root_build_dir/natives_blob.bin" 101 natives_file = "$root_build_dir/natives_blob.bin"
100 output_file = "$target_gen_dir/v8_snapshot_fingerprint.cc" 102 output_file = "$target_gen_dir/v8_snapshot_fingerprint.cc"
101 103
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 "v8_isolate_memory_dump_provider_unittest.cc", 175 "v8_isolate_memory_dump_provider_unittest.cc",
174 "wrappable_unittest.cc", 176 "wrappable_unittest.cc",
175 ] 177 ]
176 178
177 deps = [ 179 deps = [
178 ":gin_test", 180 ":gin_test",
179 "//base/test:test_support", 181 "//base/test:test_support",
180 "//v8", 182 "//v8",
181 ] 183 ]
182 } 184 }
OLDNEW
« no previous file with comments | « content/test/BUILD.gn ('k') | media/blink/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698