Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: build/config/BUILD.gn

Issue 1413893003: Move v8_use_external_startup_data out of //build/config:feature_flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_v8_module_args
Patch Set: make config be always defined Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/plugin/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/crypto.gni") 7 import("//build/config/crypto.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 import("//build/config/ui.gni") 10 import("//build/config/ui.gni")
11 import("//build_overrides/v8.gni")
12 import("//build/toolchain/goma.gni") 11 import("//build/toolchain/goma.gni")
13 12
14 declare_args() { 13 declare_args() {
15 # When set (the default) enables C++ iterator debugging in debug builds. 14 # When set (the default) enables C++ iterator debugging in debug builds.
16 # Iterator debugging is always off in release builds (technically, this flag 15 # Iterator debugging is always off in release builds (technically, this flag
17 # affects the "debug" config, which is always available but applied by 16 # affects the "debug" config, which is always available but applied by
18 # default only in debug builds). 17 # default only in debug builds).
19 # 18 #
20 # Iterator debugging is generally useful for catching bugs. But it can 19 # Iterator debugging is generally useful for catching bugs. But it can
21 # introduce extra locking to check the state of an iterator against the state 20 # introduce extra locking to check the state of an iterator against the state
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 } 235 }
237 if (enable_topchrome_md) { 236 if (enable_topchrome_md) {
238 defines += [ "ENABLE_TOPCHROME_MD=1" ] 237 defines += [ "ENABLE_TOPCHROME_MD=1" ]
239 } 238 }
240 if (proprietary_codecs) { 239 if (proprietary_codecs) {
241 defines += [ "USE_PROPRIETARY_CODECS" ] 240 defines += [ "USE_PROPRIETARY_CODECS" ]
242 } 241 }
243 if (enable_hangout_services_extension) { 242 if (enable_hangout_services_extension) {
244 defines += [ "ENABLE_HANGOUT_SERVICES_EXTENSION=1" ] 243 defines += [ "ENABLE_HANGOUT_SERVICES_EXTENSION=1" ]
245 } 244 }
246 if (v8_use_external_startup_data) {
247 defines += [ "V8_USE_EXTERNAL_STARTUP_DATA" ]
248 }
249 if (enable_background) { 245 if (enable_background) {
250 defines += [ "ENABLE_BACKGROUND=1" ] 246 defines += [ "ENABLE_BACKGROUND=1" ]
251 } 247 }
252 if (enable_pre_sync_backup) { 248 if (enable_pre_sync_backup) {
253 defines += [ "ENABLE_PRE_SYNC_BACKUP" ] 249 defines += [ "ENABLE_PRE_SYNC_BACKUP" ]
254 } 250 }
255 if (enable_video_hole) { 251 if (enable_video_hole) {
256 defines += [ "VIDEO_HOLE=1" ] 252 defines += [ "VIDEO_HOLE=1" ]
257 } 253 }
258 if (safe_browsing_mode == 1) { 254 if (safe_browsing_mode == 1) {
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 # This error doesn't happen every time. In VS2013, it seems if the .pch 439 # This error doesn't happen every time. In VS2013, it seems if the .pch
444 # file doesn't exist, no error will be generated (probably MS tested this 440 # file doesn't exist, no error will be generated (probably MS tested this
445 # case but forgot the other one?). To reproduce this error, do a build, 441 # case but forgot the other one?). To reproduce this error, do a build,
446 # then delete the precompile.c.obj file, then build again. 442 # then delete the precompile.c.obj file, then build again.
447 cflags_c = [ "/wd4206" ] 443 cflags_c = [ "/wd4206" ]
448 } else if (is_mac && !is_official_build && !use_goma) { 444 } else if (is_mac && !is_official_build && !use_goma) {
449 precompiled_header = "build/precompile.h" 445 precompiled_header = "build/precompile.h"
450 precompiled_source = "//build/precompile.h" 446 precompiled_source = "//build/precompile.h"
451 } 447 }
452 } 448 }
OLDNEW
« no previous file with comments | « no previous file | chrome/plugin/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698