Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1413883005: More master side changes for convergence with XFA. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More master side changes for convergence with XFA. - Add new CPDFSDK_Document::GetPDFDocument() - FPDFDocumentFromCPDFDocument() to match XFA - rename some JS variables to be consistent with XFA - remove unused param from CJS_GlobalData(). - kill dead code used XFA only. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/69ceb6a9761b3ccb228a2405e9a493a3666e0601

Patch Set 1 #

Patch Set 2 : Remove fn. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M fpdfsdk/include/fsdk_define.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +8 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 3 chunks +6 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 11 chunks +12 lines, -16 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Define.h View 3 chunks +6 lines, -8 lines 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.h View 2 chunks +1 line, -2 lines 1 comment Download
M fpdfsdk/src/javascript/JS_GlobalData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, for review.
5 years, 2 months ago (2015-10-21 21:53:20 UTC) #3
Lei Zhang
Looking. I did s/wit/with/ in the commit msg.
5 years, 2 months ago (2015-10-21 22:25:46 UTC) #5
Lei Zhang
lgtm https://codereview.chromium.org/1413883005/diff/20001/fpdfsdk/src/javascript/JS_GlobalData.h File fpdfsdk/src/javascript/JS_GlobalData.h (left): https://codereview.chromium.org/1413883005/diff/20001/fpdfsdk/src/javascript/JS_GlobalData.h#oldcode101 fpdfsdk/src/javascript/JS_GlobalData.h:101: private: these always through me off
5 years, 2 months ago (2015-10-21 22:27:37 UTC) #6
Tom Sepez
5 years, 2 months ago (2015-10-21 22:55:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
69ceb6a9761b3ccb228a2405e9a493a3666e0601 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698