Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: content/test/gpu/gpu_tests/maps.py

Issue 1413883003: Add a presubmit script and pylintrc for content/test/gpu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address kbr's comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/gpu/gpu_tests/maps.py
diff --git a/content/test/gpu/gpu_tests/maps.py b/content/test/gpu/gpu_tests/maps.py
index 5a007fc56b6f5de664f1d24b4a890b5c92b3a7f6..21aafa557943a8d8d9eee835cbc2360b13ff5063 100644
--- a/content/test/gpu/gpu_tests/maps.py
+++ b/content/test/gpu/gpu_tests/maps.py
@@ -7,13 +7,12 @@ Performs several common navigation actions on the map (pan, zoom, rotate) then
captures a screenshot and compares selected pixels against expected values"""
import json
-import optparse
import os
-import cloud_storage_test_base
-import gpu_test_base
-import maps_expectations
-import path_util
+from gpu_tests import cloud_storage_test_base
+from gpu_tests import gpu_test_base
+from gpu_tests import maps_expectations
+from gpu_tests import path_util
from telemetry.core import util
from telemetry.page import page_test
@@ -21,6 +20,9 @@ from telemetry import story as story_module
from telemetry.story import story_set as story_set_module
class MapsValidator(cloud_storage_test_base.ValidatorBase):
+ def __init__(self):
+ super(MapsValidator, self).__init__()
+
def CustomizeBrowserOptions(self, options):
# --test-type=gpu is used only to suppress the "Google API Keys are missing"
# infobar, which causes flakiness in tests.
@@ -45,7 +47,7 @@ class MapsValidator(cloud_storage_test_base.ValidatorBase):
page.display_name, screenshot, expected, dpr)
@staticmethod
- def SpinWaitOnRAF(tab, iterations, timeout = 60):
+ def SpinWaitOnRAF(tab, iterations, timeout=60):
waitScript = r"""
window.__spinWaitOnRAFDone = false;
var iterationsLeft = %d;

Powered by Google App Engine
This is Rietveld 408576698