Add a presubmit script and pylintrc for content/test/gpu

content/test/gpu/gpu_tests/gpu_test_base.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from telemetry import benchmark as benchmark_module
-from telemetry.core import exceptions
 from telemetry.page import page as page_module
 from telemetry.page import page_test
 from telemetry.page import shared_page_state
 from telemetry.testing import fakes
-from telemetry.value import skip
 
-import exception_formatter
-import gpu_test_expectations
-
-"""Base classes for all GPU tests in this directory. Implements
-support for per-page test expectations."""
+from gpu_tests import exception_formatter
+from gpu_tests import gpu_test_expectations
 
 class TestBase(benchmark_module.Benchmark):
+  """Base classes for all GPU tests in this directory. Implements
+  support for per-page test expectations."""
+
   def __init__(self, max_failures=None):
     super(TestBase, self).__init__(max_failures=max_failures)
     self._cached_expectations = None
 
   def GetExpectations(self):
     """Returns the expectations that apply to this test."""
     if not self._cached_expectations:
       self._cached_expectations = self._CreateExpectations()
     if not isinstance(self._cached_expectations,
                       gpu_test_expectations.GpuTestExpectations):
@@ skipping 13 matching lines @@
 # future.
 class ValidatorBase(page_test.PageTest):
   def __init__(self,
                needs_browser_restart_after_each_page=False,
                clear_cache_before_each_run=False):
     super(ValidatorBase, self).__init__(
       needs_browser_restart_after_each_page=\
         needs_browser_restart_after_each_page,
       clear_cache_before_each_run=clear_cache_before_each_run)
 
+  def ValidateAndMeasurePage(self, page, tab, result):

[Ken Russell (switch to Gerrit), 2015/10/21 22:12:08]

Again, unfortunate that useless code is required to satisfy pylint.

[Corentin Wallez, 2015/10/21 23:07:25]

Acknowledged.

+    pass
 
 def _CanRunOnBrowser(browser_info, page):
   expectations = page.GetExpectations()
   return expectations.GetExpectationForPage(
     browser_info.browser, page) != 'skip'
 
-def RunStoryWithRetries(cls, shared_page_state, results):
-  page = shared_page_state.current_page
+def RunStoryWithRetries(cls, shared_state, results):

[Ken Russell (switch to Gerrit), 2015/10/21 22:12:08]

Consider importing shared_page_state as shared_page_state_module so that these
variable renamings can be avoided.

[Corentin Wallez, 2015/10/21 23:07:25]

Done.

+  page = shared_state.current_page
   expectations = page.GetExpectations()
   expectation = 'pass'
   if expectations:
     expectation = expectations.GetExpectationForPage(
-      shared_page_state.browser, page)
+      shared_state.browser, page)
   if expectation == 'skip':
     raise Exception(
       'Skip expectations should have been handled in CanRunOnBrowser')
   try:
-    super(cls, shared_page_state).RunStory(results)
+    super(cls, shared_state).RunStory(results)
   except Exception:
     if expectation == 'pass':
       raise
     elif expectation == 'fail':
       msg = 'Expected exception while running %s' % page.display_name
       exception_formatter.PrintFormattedException(msg=msg)
       return
     if expectation != 'flaky':
       logging.warning(
-          'Unknown expectation %s while handling exception for %s' %
-          (expectation, page.display_name))
+          'Unknown expectation %s while handling exception for %s',
+          expectation, page.display_name)
       raise
     # Flaky tests are handled here.
     num_retries = expectations.GetFlakyRetriesForPage(
-      shared_page_state.browser, page)
+      shared_state.browser, page)
     if not num_retries:
       # Re-raise the exception.
       raise
     # Re-run the test up to |num_retries| times.
     for ii in xrange(0, num_retries):
       print 'FLAKY TEST FAILURE, retrying: ' + page.display_name
       try:
-        super(cls, shared_page_state).RunStory(results)
+        super(cls, shared_state).RunStory(results)
         break
       except Exception:
         # Squelch any exceptions from any but the last retry.
         if ii == num_retries - 1:
           raise
   else:
     if expectation == 'fail':
       logging.warning(
           '%s was expected to fail, but passed.\n', page.display_name)
 
@@ skipping 50 matching lines @@
 
 
     # TODO(kbr): this is fragile -- if someone changes the
     # shared_page_state_class to something that doesn't handle skip
     # expectations, then they'll hit the exception in
     # RunStoryWithRetries, above. Need to rethink.
     self._expectations = expectations
 
   def GetExpectations(self):
     return self._expectations