Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1413863008: [NaCl SDK] Use gyp_nacl when building NaCl components via gyp (Closed)

Created:
5 years, 1 month ago by Sam Clegg
Modified:
5 years, 1 month ago
Reviewers:
binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Use gyp_nacl when building NaCl components via gyp This fixes an the Mac SDK build which was failing due to an incompatibility between chromium's chommon.gypi and some of the untrusted targets in the NaCl tree. Chromium's common.gypi was assuming all NaCl untrusted targets define nacl_untrusted_build and adding libc++ headers to the include path for all non-nacl targets. This was causing build failures since the libc++ headers are not compatible with the old version of gcc used by NaCl. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk Committed: https://crrev.com/99c43acddde02a9cf9b2759ec80bca9983984a82 Cr-Commit-Position: refs/heads/master@{#356357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Sam Clegg
5 years, 1 month ago (2015-10-27 04:09:35 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413863008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413863008/1
5 years, 1 month ago (2015-10-27 04:09:40 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-27 06:16:23 UTC) #8
binji
lgtm
5 years, 1 month ago (2015-10-27 17:43:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413863008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413863008/1
5 years, 1 month ago (2015-10-27 18:56:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 19:05:32 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 19:06:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99c43acddde02a9cf9b2759ec80bca9983984a82
Cr-Commit-Position: refs/heads/master@{#356357}

Powered by Google App Engine
This is Rietveld 408576698