Chromium Code Reviews Chromium Code Reviews
Issue 1413863006:
Change BrowsingInstance when changing WebUI type. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "base/command_line.h" | |
| 6 #include "chrome/browser/ui/browser.h" | |
| 7 #include "chrome/browser/ui/tabs/tab_strip_model.h" | |
| 8 #include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h" | |
| 9 #include "chrome/common/chrome_switches.h" | |
| 10 #include "chrome/common/url_constants.h" | |
| 11 #include "chrome/test/base/in_process_browser_test.h" | |
| 12 #include "chrome/test/base/ui_test_utils.h" | |
| 13 #include "content/public/browser/child_process_security_policy.h" | |
| 14 #include "content/public/browser/render_process_host.h" | |
| 15 #include "content/public/common/content_switches.h" | |
| 16 #include "content/public/test/test_utils.h" | |
| 17 | |
| 18 typedef InProcessBrowserTest WebUIBrowserTest; | |
|
Lei Zhang
2015/10/24 00:21:23
nit: using foo = bar instead of typedef bar foo
nasko
2015/10/24 00:30:49
Done.
| |
| 19 | |
| 20 // Tests that navigating between WebUIs of different types results in | |
| 21 // SiteInstance swap when running in process-per-tab process model. | |
| 22 IN_PROC_BROWSER_TEST_F(WebUIBrowserTest, ForceSwapOnDifferenteWebUITypes) { | |
| 23 base::CommandLine::ForCurrentProcess()->AppendSwitch( | |
| 24 switches::kProcessPerTab); | |
| 25 content::WebContents* web_contents = | |
| 26 browser()->tab_strip_model()->GetActiveWebContents(); | |
| 27 | |
| 28 const GURL web_ui_url(std::string(content::kChromeUIScheme) + "://" + | |
| 29 std::string(chrome::kChromeUIFlagsHost)); | |
| 30 EXPECT_TRUE(ChromeWebUIControllerFactory::GetInstance()->UseWebUIForURL( | |
| 31 web_contents->GetBrowserContext(), web_ui_url)); | |
| 32 ui_test_utils::NavigateToURL(browser(), web_ui_url); | |
| 33 EXPECT_TRUE( | |
| 34 content::ChildProcessSecurityPolicy::GetInstance()->HasWebUIBindings( | |
| 35 web_contents->GetRenderProcessHost()->GetID())); | |
| 36 | |
| 37 // Capture the SiteInstance befor navigating for later comparison. | |
|
Charlie Reis
2015/10/24 00:19:22
nit: before
nasko
2015/10/24 00:30:48
Done.
| |
| 38 scoped_refptr<content::SiteInstance> orig_site_instance( | |
| 39 web_contents->GetSiteInstance()); | |
| 40 | |
| 41 // Navigate to a different WebUI type and ensure that the SiteInstance | |
| 42 // has changed and the process still has WebUI bindings. | |
|
Charlie Reis
2015/10/24 00:19:22
s/process still/new process also/
nasko
2015/10/24 00:30:49
Done.
| |
| 43 const GURL web_ui_url2(std::string(content::kChromeUIScheme) + "://" + | |
| 44 std::string(chrome::kChromeUIVersionHost)); | |
| 45 EXPECT_TRUE(ChromeWebUIControllerFactory::GetInstance()->UseWebUIForURL( | |
| 46 web_contents->GetBrowserContext(), web_ui_url2)); | |
| 47 ui_test_utils::NavigateToURL(browser(), web_ui_url2); | |
| 48 EXPECT_NE(orig_site_instance, web_contents->GetSiteInstance()); | |
| 49 EXPECT_TRUE( | |
| 50 content::ChildProcessSecurityPolicy::GetInstance()->HasWebUIBindings( | |
| 51 web_contents->GetRenderProcessHost()->GetID())); | |
| 52 } | |
| OLD | NEW |
