Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413863004: Rename the _fletch_system and service and dart: libraries (Closed)

Created:
5 years, 2 months ago by Søren Gjesse
Modified:
5 years, 2 months ago
CC:
fletch+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/fletch.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename the _fletch_system and service and dart: libraries Renamed dart:_fletch_system to dart:fletch._system Renamed dart:service to dart:fletch.service Removed reference dart:system from the compiler since it no longer existed. Closes #239 R=ager@google.com, ahe@google.com, zerny@google.com BUG= Committed: https://github.com/dart-lang/fletch/commit/60442aeb572103f9e9679e0691fdee690e4747db

Patch Set 1 #

Patch Set 2 : Fixes after self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -37 lines) Patch
M lib/async/async_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/collection/collection_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/core_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/ffi/ffi.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/fletch/fletch.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/internal/internal_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/math/math_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/os/os.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/service/service.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/system/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/system/map.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/system/nsm.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/system/system.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/typed_data/typed_data_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/fletch/lib/_sdkext View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/fletchc/lib/src/fletch_backend.dart View 1 4 chunks +3 lines, -6 lines 0 comments Download
M pkg/fletchc/lib/src/fletch_compiler_implementation.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M samples/buildbot/dart/buildbot_service.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/todomvc/dart/todomvc_service.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/service_tests/multiple_services/dart/service_one.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/service_tests/multiple_services/dart/service_two.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/servicec/lib/src/plugins/dart.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
5 years, 2 months ago (2015-10-23 10:07:15 UTC) #1
ahe
lgtm
5 years, 2 months ago (2015-10-23 10:22:33 UTC) #2
Mads Ager (google)
LGTM!
5 years, 2 months ago (2015-10-23 10:53:59 UTC) #3
Søren Gjesse
5 years, 2 months ago (2015-10-23 12:05:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
60442aeb572103f9e9679e0691fdee690e4747db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698