chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc - Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions

Unified Diff: chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits, git cl format, fix error in ExtensionWebContentsObserver::GetExtensionFromFrame, exclude kGue… Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_apitest.cc ('k') | chrome/browser/extensions/chrome_extensions_browser_client.cc » ('j') | chrome/browser/extensions/process_manager_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

diff --git a/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc b/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

index 93d90f4f8a006d766fe64640a3b145c238dd8b92..5a516f814fc391312e0da50202c32425adf41f6c 100644

--- a/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

+++ b/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

@@ -60,6 +60,9 @@ InspectableViewsFinder::View InspectableViewsFinder::ConstructView(

case VIEW_TYPE_EXTENSION_DIALOG:

view->type = api::developer_private::VIEW_TYPE_EXTENSION_DIALOG;

break;

+ case VIEW_TYPE_EXTENSION_GUEST:

+ view->type = api::developer_private::VIEW_TYPE_EXTENSION_GUEST;

+ break;

case VIEW_TYPE_EXTENSION_POPUP:

view->type = api::developer_private::VIEW_TYPE_EXTENSION_POPUP;

break;

@@ -149,7 +152,8 @@ void InspectableViewsFinder::GetViewsForExtensionProcess(

content::WebContents::FromRenderFrameHost(host);

ViewType host_type = GetViewType(web_contents);

if (host_type == VIEW_TYPE_EXTENSION_POPUP ||

- host_type == VIEW_TYPE_EXTENSION_DIALOG) {

+ host_type == VIEW_TYPE_EXTENSION_DIALOG ||

+ host_type == VIEW_TYPE_APP_WINDOW) {

Devlin 2015/12/01 21:40:49 Why don't we want to include APP_WINDOW here? Thi

robwu 2015/12/01 23:19:57 App windows are already dealt with by GetAppWindow

Devlin 2015/12/01 23:29:58 Ah, of course.

continue;

}