extensions/browser/guest_view/extension_options/extension_options_guest.cc - Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits, treat hosted apps as extensions, no test flakiness Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/extension_web_contents_observer.cc ('K') | « extensions/browser/extension_web_contents_observer.cc ('k') | extensions/browser/process_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_options/extension_options_guest.cc

diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.cc b/extensions/browser/guest_view/extension_options/extension_options_guest.cc

index 6a34aa01a7b2d8f1033e74a85c09928ac3c7b148..7015146426befb40cfcd16ebaa7e0d0d9499a711 100644

--- a/extensions/browser/guest_view/extension_options/extension_options_guest.cc

+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.cc

@@ -19,6 +19,7 @@

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/guest_view/extension_options/extension_options_constants.h"

#include "extensions/browser/guest_view/extension_options/extension_options_guest_delegate.h"

+#include "extensions/browser/view_type_utils.h"

#include "extensions/common/api/extension_options_internal.h"

#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

@@ -108,7 +109,9 @@ void ExtensionOptionsGuest::CreateWebContents(

content::SiteInstance::CreateForURL(browser_context(), extension_url);

WebContents::CreateParams params(browser_context(), options_site_instance);

params.guest_delegate = this;

- callback.Run(WebContents::Create(params));

+ WebContents* wc = WebContents::Create(params);

+ SetViewType(wc, VIEW_TYPE_EXTENSION_OPTIONS);

+ callback.Run(wc);

}

void ExtensionOptionsGuest::DidInitialize(