extensions/browser/extension_web_contents_observer.h - Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_web_contents_observer.h

Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add ProcessManagerObserver::OnExtensionFrameNavigated notification Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/process_manager_browsertest.cc ('K') | « chrome/test/data/extensions/api_test/messaging/connect_nobackground/test.js ('k') | extensions/browser/extension_web_contents_observer.cc » ('j') | extensions/browser/extension_web_contents_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_web_contents_observer.h

diff --git a/extensions/browser/extension_web_contents_observer.h b/extensions/browser/extension_web_contents_observer.h

index c92ad9c0a0478f21adb4fd49af821040d3378570..3643271a7eeaf561100aaffa7044065f920e0825 100644

--- a/extensions/browser/extension_web_contents_observer.h

+++ b/extensions/browser/extension_web_contents_observer.h

@@ -60,6 +60,11 @@ class ExtensionWebContentsObserver

void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;

void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override;

+ void RenderFrameHostChanged(content::RenderFrameHost* old_host,

+ content::RenderFrameHost* new_host) override;

+ void DidNavigateAnyFrame(content::RenderFrameHost* render_frame_host,

+ const content::LoadCommittedDetails& details,

+ const content::FrameNavigateParams& params) override;

// Subclasses should call this first before doing their own message handling.

bool OnMessageReceived(const IPC::Message& message,