Track all extension frames in ProcessManager, inspect extensionoptions

extensions/browser/guest_view/extension_options/extension_options_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/extension_options/extension_options_guest.h"
 
 #include "base/values.h"
 #include "components/crx_file/id_util.h"
 #include "components/guest_view/browser/guest_view_event.h"
 #include "components/guest_view/browser/guest_view_manager.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/result_codes.h"
 #include "extensions/browser/api/extensions_api_client.h"
 #include "extensions/browser/bad_message.h"
 #include "extensions/browser/extension_function_dispatcher.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/guest_view/extension_options/extension_options_constants.h"
 #include "extensions/browser/guest_view/extension_options/extension_options_guest_delegate.h"
+#include "extensions/browser/view_type_utils.h"
 #include "extensions/common/api/extension_options_internal.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/manifest_handlers/options_page_info.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "extensions/strings/grit/extensions_strings.h"
 #include "ipc/ipc_message_macros.h"
 
 using content::WebContents;
@@ skipping 69 matching lines @@
     return;
   }
 
   // Create a WebContents using the extension URL. The options page's
   // WebContents should live in the same process as its parent extension's
   // WebContents, so we can use |extension_url| for creating the SiteInstance.
   content::SiteInstance* options_site_instance =
       content::SiteInstance::CreateForURL(browser_context(), extension_url);
   WebContents::CreateParams params(browser_context(), options_site_instance);
   params.guest_delegate = this;
-  callback.Run(WebContents::Create(params));
+  WebContents* wc = WebContents::Create(params);
+  SetViewType(wc, VIEW_TYPE_EXTENSION_OPTIONS);

[Fady Samuel, 2015/11/01 21:53:29]

This seems incomplete? What about other GuestView types? I recommend moving this
line of code to GuestViewBase::InitWithWebContents:

Create a pure virtual function on GuestViewBase called GetViewTypeID.


https://code.google.com/p/chromium/codesearch#chromium/src/components/guest_v...

I'd also add a TODO(fsamuel, paulmeyer) above GuestViewBase::GetViewType to
replace it with GetViewTypeID (I don't want to make you do that). Ideally,
please file a bug with label Cr-Platform-Apps-BrowserTag, set paulmeyer@ as the
owner and CC myself fsamuel@, and Mike Knowles (GuestView manager) mknowles@.

Thanks!

[Fady Samuel, 2015/11/01 22:09:55]

Nevermind, chrome.extensions.getViews() should not see all GuestView types.
GuestView lgtm.

+  callback.Run(wc);
 }
 
 void ExtensionOptionsGuest::DidInitialize(
     const base::DictionaryValue& create_params) {
   ExtensionsAPIClient::Get()->AttachWebContentsHelpers(web_contents());
   web_contents()->GetController().LoadURL(options_page_,
                                           content::Referrer(),
                                           ui::PAGE_TRANSITION_LINK,
                                           std::string());
 }
@@ skipping 105 matching lines @@
     SetGuestZoomLevelToMatchEmbedder();
 
     if (params.url.GetOrigin() != options_page_.GetOrigin()) {
       bad_message::ReceivedBadMessage(web_contents()->GetRenderProcessHost(),
                                       bad_message::EOG_BAD_ORIGIN);
     }
   }
 }
 
 }  // namespace extensions