Track all extension frames in ProcessManager, inspect extensionoptions

extensions/browser/process_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/process_manager.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 148 matching lines @@
 
   ExtensionRenderFrameData()
       : view_type(VIEW_TYPE_INVALID), has_keepalive(false) {}
 
   // Returns whether the view can keep the lazy background page alive or not.
   bool CanKeepalive() const {
     switch (view_type) {
       case VIEW_TYPE_APP_WINDOW:
       case VIEW_TYPE_BACKGROUND_CONTENTS:
       case VIEW_TYPE_EXTENSION_DIALOG:
+      case VIEW_TYPE_EXTENSION_OPTIONS:
       case VIEW_TYPE_EXTENSION_POPUP:
       case VIEW_TYPE_LAUNCHER_PAGE:
       case VIEW_TYPE_PANEL:
       case VIEW_TYPE_TAB_CONTENTS:
       case VIEW_TYPE_VIRTUAL_KEYBOARD:
         return true;
 
       case VIEW_TYPE_INVALID:
       case VIEW_TYPE_EXTENSION_BACKGROUND_PAGE:
         return false;
@@ skipping 123 matching lines @@
     ReleaseLazyKeepaliveCountForFrame(render_frame_host);
     all_extension_frames_.erase(frame);
 
     FOR_EACH_OBSERVER(ProcessManagerObserver,
                       observer_list_,
                       OnExtensionFrameUnregistered(extension_id,
                                                    render_frame_host));
   }
 }
 
+void ProcessManager::DidNavigateRenderFrameHost(
+    content::RenderFrameHost* render_frame_host) {
+  ExtensionRenderFrames::iterator frame =
+      all_extension_frames_.find(render_frame_host);
+
+  if (frame != all_extension_frames_.end()) {
+    std::string extension_id = GetExtensionID(render_frame_host);
+
+    FOR_EACH_OBSERVER(ProcessManagerObserver,
+                      observer_list_,
+                      OnExtensionFrameNavigated(extension_id,
+                                                render_frame_host));
+  }
+}
+
 scoped_refptr<content::SiteInstance> ProcessManager::GetSiteInstanceForURL(
     const GURL& url) {
   return make_scoped_refptr(site_instance_->GetRelatedSiteInstance(url));
 }
 
 const ProcessManager::FrameSet ProcessManager::GetAllFrames() const {
   FrameSet result;
   for (const auto& key_value : all_extension_frames_)
     result.insert(key_value.first);
   return result;
 }
 
 ProcessManager::FrameSet ProcessManager::GetRenderFrameHostsForExtension(
     const std::string& extension_id) {
   FrameSet result;
-  scoped_refptr<content::SiteInstance> site_instance(GetSiteInstanceForURL(
-      Extension::GetBaseURLFromExtensionId(extension_id)));
-  if (!site_instance.get())
-    return result;
-
-  // Gather up all the frames for that site.
   for (const auto& key_value : all_extension_frames_) {
-    if (key_value.first->GetSiteInstance() == site_instance)
+    if (GetExtensionID(key_value.first) == extension_id)

[ncarter (slow), 2015/11/05 20:03:23]

This will result in a match even if key_value's SiteInstance is for the
kGuestScheme. Is that an intended difference? Does it matter?

[robwu, 2015/11/12 00:33:58]

I don't know. For now I'll assume that chrome-guest:// is chrome-extension://,
but I'll double-check with Fady before landing the patch.

       result.insert(key_value.first);
   }
-
   return result;
 }
 
 void ProcessManager::AddObserver(ProcessManagerObserver* observer) {
   observer_list_.AddObserver(observer);
 }
 
 void ProcessManager::RemoveObserver(ProcessManagerObserver* observer) {
   observer_list_.RemoveObserver(observer);
 }
@@ skipping 613 matching lines @@
   if (extension && !IncognitoInfo::IsSplitMode(extension)) {
     BrowserContext* original_context =
         ExtensionsBrowserClient::Get()->GetOriginalContext(browser_context());
     return ProcessManager::Get(original_context)->GetSiteInstanceForURL(url);
   }
 
   return ProcessManager::GetSiteInstanceForURL(url);
 }
 
 }  // namespace extensions