content/renderer/media/android/webmediaplayer_android.h - Issue 1413833006: Reland of "webgl: optimize webgl.texSubImage2D(video) path."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 1413833006: Reland of "webgl: optimize webgl.texSubImage2D(video) path." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add TODO comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/android/webmediaplayer_android.h

diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h

index bb338153f8fac37a3809049b86557513c440d313..6b8090f0c30366b1a8c20921a0e033a80d19d695 100644

--- a/content/renderer/media/android/webmediaplayer_android.h

+++ b/content/renderer/media/android/webmediaplayer_android.h

@@ -138,11 +138,7 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,

bool copyVideoTextureToPlatformTexture(

blink::WebGraphicsContext3D* web_graphics_context,

- unsigned int texture,

- unsigned int internal_format,

- unsigned int type,

- bool premultiply_alpha,

- bool flip_y) override;

+ const CopyVideoTextureParams& params) override;

// True if the loaded media has a playable video/audio track.

virtual bool hasVideo() const;

« no previous file with comments | « no previous file | content/renderer/media/android/webmediaplayer_android.cc » ('j') | no next file with comments »