Window capture stop draw cursor when it points to the hidden content.

Fix window capture drawing cursor pointing to the hidden content.

When the target window is inactive, window capture should stop draw the
cursor if it points to the hidden content.

BUG=543231
Committed: https://crrev.com/ec15486457e6102cda0f78872e2201fe8f787950
Cr-Commit-Position: refs/heads/master@{#354945}

[xjz, 2015-10-17 01:21:24]

xjz@chromium.org changed reviewers:
+ isheriff@chromium.org, miu@chromium.org

[miu, 2015-10-19 19:49:47]

https://codereview.chromium.org/1413803002/diff/1/content/browser/media/captu...
File content/browser/media/capture/aura_window_capture_machine.cc (right):

https://codereview.chromium.org/1413803002/diff/1/content/browser/media/captu...
content/browser/media/capture/aura_window_capture_machine.cc:424: if
(active_window->GetBoundsInScreen().Contains(cursor_position)) {
This mostly works.  It wouldn't if there were TWO windows on top of the window
being mirrored.  ;-)

However, I think you're on the right track here.  IMO, it would be reasonable to
simply shut off the cursor if the mirrored window is not the currently-active
window (or a parent of it).  Meaning, just do:

  if (!desktop_window_->Contains(active_window)) {
    ClearCursorState();
    return gfx::Point();
  }

BTW--After doing this, you don't need the DCHECK(active_window) statement since
the Window::Contains() will safely handle null pointers.

[xjz, 2015-10-20 00:03:21]

PTAL

https://codereview.chromium.org/1413803002/diff/1/content/browser/media/captu...
File content/browser/media/capture/aura_window_capture_machine.cc (right):

https://codereview.chromium.org/1413803002/diff/1/content/browser/media/captu...
content/browser/media/capture/aura_window_capture_machine.cc:424: if
(active_window->GetBoundsInScreen().Contains(cursor_position)) {
On 2015/10/19 19:49:47, miu wrote:
> This mostly works.  It wouldn't if there were TWO windows on top of the window
> being mirrored.  ;-)
> 
> However, I think you're on the right track here.  IMO, it would be reasonable
to
> simply shut off the cursor if the mirrored window is not the currently-active
> window (or a parent of it).  Meaning, just do:
> 
>   if (!desktop_window_->Contains(active_window)) {
>     ClearCursorState();
>     return gfx::Point();
>   }
> 
> BTW--After doing this, you don't need the DCHECK(active_window) statement
since
> the Window::Contains() will safely handle null pointers.

Done.

[miu, 2015-10-20 00:35:42]

lgtm

[xjz, 2015-10-20 01:05:52]

The CQ bit was checked by xjz@chromium.org

[commit-bot: I haz the power, 2015-10-20 01:06:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413803002/20001

[commit-bot: I haz the power, 2015-10-20 01:11:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-20 01:12:45]

Patchset 2 (id:??) landed as
https://crrev.com/ec15486457e6102cda0f78872e2201fe8f787950
Cr-Commit-Position: refs/heads/master@{#354945}