Issue 1413783010: [turbofan] Remove unused BuildLoadGlobalProxy from AstGraphBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413783010: [turbofan] Remove unused BuildLoadGlobalProxy from AstGraphBuilder. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer

Modified:
5 years, 1 month ago

Reviewers:
Jarin

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Remove unused BuildLoadGlobalProxy from AstGraphBuilder. R=jarin@chromium.org Committed: https://crrev.com/339f0439e1e07a6e040a6582add8fdb084af3caa Cr-Commit-Position: refs/heads/master@{#31880}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	src/compiler/ast-graph-builder.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/compiler/ast-graph-builder.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Benedikt Meurer

Hey Jaro, Dead code should be dead :-) Please take a look. Thanks, Benedikt

5 years, 1 month ago (2015-11-09 11:36:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413783010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413783010/1

5 years, 1 month ago (2015-11-09 12:48:34 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-11-09 12:50:46 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/339f0439e1e07a6e040a6582add8fdb084af3caa
Cr-Commit-Position: refs/heads/master@{#31880}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages