Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 1413783005: `LineInfo` line-end detection fixes. (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -10 lines) Patch
M pkg/analysis_server/test/integration/analysis/analysis_options_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 2 chunks +22 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 1 month ago (2015-10-27 16:35:46 UTC) #2
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-10-27 16:37:22 UTC) #3
pquitslund
5 years, 1 month ago (2015-10-27 16:39:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c4ccdb462ad0726977a78a3e476cbe9dd77f3a53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698