Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: BUILD.gn

Issue 1413783003: Make chrome and other targets compile on Mac GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ChromeOS fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/toolchain/mac/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 } 487 }
488 } 488 }
489 489
490 if (is_mac) { 490 if (is_mac) {
491 deps += [ 491 deps += [
492 "//breakpad:crash_inspector", 492 "//breakpad:crash_inspector",
493 "//breakpad:dump_syms", 493 "//breakpad:dump_syms",
494 "//third_party/apple_sample_code", 494 "//third_party/apple_sample_code",
495 "//third_party/molokocacao", 495 "//third_party/molokocacao",
496 ] 496 ]
497
498 # TODO(GYP): These don't work on Mac yet.
Bons 2015/10/23 14:16:01 THEY DO NOW :)
499 deps -= [ 497 deps -= [
500 "//chrome", # TODO(GYP)
501 "//chrome/test:browser_tests", # TODO(GYP)
502 "//chrome/test:interactive_ui_tests", # TODO(GYP)
503 "//chrome/test:sync_integration_tests", # TODO(GYP)
504 "//extensions:extensions_browsertests", # TODO(GYP) Needs ContentMain
505
506 # Mojo in GN contains some things which are never compiled in GYP on Mac, 498 # Mojo in GN contains some things which are never compiled in GYP on Mac,
507 # so compilation fails on Mac. They need porting. 499 # so compilation fails on Mac. They need porting.
508 "//mojo", # TODO(GYP) 500 "//mojo",
509 ] 501 ]
510 } 502 }
511 503
512 if (is_win) { 504 if (is_win) {
513 deps += [ 505 deps += [
514 "//base:pe_image_test", 506 "//base:pe_image_test",
515 "//chrome/installer/setup:setup_unittests", 507 "//chrome/installer/setup:setup_unittests",
516 "//chrome_elf:chrome_elf_unittests", 508 "//chrome_elf:chrome_elf_unittests",
517 "//chrome_elf:dll_hash_main", 509 "//chrome_elf:dll_hash_main",
518 "//cloud_print/service/win:cloud_print_service", 510 "//cloud_print/service/win:cloud_print_service",
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
787 if (target_cpu == "x86") { 779 if (target_cpu == "x86") {
788 deps += [ 780 deps += [
789 # "//content/shell:crash_service_win64", TODO(GYP): crbug.com/537009 781 # "//content/shell:crash_service_win64", TODO(GYP): crbug.com/537009
790 ] 782 ]
791 } 783 }
792 } else { 784 } else {
793 deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ] 785 deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
794 } 786 }
795 } 787 }
796 } 788 }
OLDNEW
« no previous file with comments | « no previous file | build/toolchain/mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698