Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1413773009: Revert of Run Mojo apptests step on Windows main and cq bots. (Closed)

Created:
5 years, 1 month ago by msw
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Run Mojo apptests step on Windows main and cq bots. (patchset #2 id:20001 of https://codereview.chromium.org/1412563007/ ) Reason for revert: The mojo_apptests step is failing flakily due to a high incidence rate of http://crbug.com/551083 (Flaky mojo BaseThreadInitThunk / RtlInitializeExceptionChain crashes on Windows) Original issue's description: > Run Mojo apptests step on Windows main and cq bots. > > Add mojo_apptests step to 'Win8 Aura' buildbot config for these bots: > http://build.chromium.org/p/chromium.win/builders/Win8%20Aura > http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng > > The step has run on FYI for months, with no flakes for 1 week: > http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Windows > (recent changes addressed blocking flakiness: http://crbug.com/517661) > > BUG=478244, 517661 > TEST=New step passes on intended bots. > R=dpranke@chromium.org > TBR=phajdan.jr@chromium.org > > Committed: https://crrev.com/3e18cf082b743ba0209a38509f2b62f0c9b76638 > Cr-Commit-Position: refs/heads/master@{#357425} TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=478244, 517661 Committed: https://crrev.com/e3faad772792c9be1254bcc72aa4ce05ac810415 Cr-Commit-Position: refs/heads/master@{#358105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M testing/buildbot/chromium.win.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/scripts/mojo_apptests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
Created Revert of Run Mojo apptests step on Windows main and cq bots.
5 years, 1 month ago (2015-11-05 19:20:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413773009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413773009/1
5 years, 1 month ago (2015-11-05 19:21:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 19:22:23 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 19:23:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3faad772792c9be1254bcc72aa4ce05ac810415
Cr-Commit-Position: refs/heads/master@{#358105}

Powered by Google App Engine
This is Rietveld 408576698