Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1413763018: Omit unused code metadata from precompiled snapshots. (Closed)

Created:
5 years, 1 month ago by rmacnak
Modified:
5 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Omit nonessential code metadata from precompiled snapshots. dart2js ARM -9.9% size Before VMIsolate(CodeSize): 2627828 Isolate(CodeSize): 11977642 Instructions(CodeSize): 12908480 Total(CodeSize): 27513950 After VMIsolate(CodeSize): 2627206 Isolate(CodeSize): 9247198 Instructions(CodeSize): 12908512 Total(CodeSize): 24782916 BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/73b6080a6b26ad24380477c4a584edd6cb2e2ab5

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -20 lines) Patch
M runtime/vm/raw_object.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 5 chunks +31 lines, -19 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 1 month ago (2015-11-13 20:48:27 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1413763018/diff/40001/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://codereview.chromium.org/1413763018/diff/40001/runtime/vm/raw_object_snapshot.cc#newcode754 runtime/vm/raw_object_snapshot.cc:754: if (!writer->snapshot_code()) { ditto
5 years, 1 month ago (2015-11-13 21:14:02 UTC) #3
rmacnak
https://codereview.chromium.org/1413763018/diff/40001/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://codereview.chromium.org/1413763018/diff/40001/runtime/vm/raw_object_snapshot.cc#newcode754 runtime/vm/raw_object_snapshot.cc:754: if (!writer->snapshot_code()) { On 2015/11/13 21:14:02, srdjan wrote: > ...
5 years, 1 month ago (2015-11-13 21:56:02 UTC) #4
rmacnak
5 years, 1 month ago (2015-11-13 21:56:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
73b6080a6b26ad24380477c4a584edd6cb2e2ab5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698