Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: cc/output/direct_renderer.cc

Issue 1413763013: Avoid rendering using GL in case damage rect is composited by overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | cc/output/overlay_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/direct_renderer.h" 5 #include "cc/output/direct_renderer.h"
6 6
7 #include <utility> 7 #include <utility>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/containers/hash_tables.h" 10 #include "base/containers/hash_tables.h"
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 output_surface_plane.overlay_handled = true; 235 output_surface_plane.overlay_handled = true;
236 frame.overlay_list.push_back(output_surface_plane); 236 frame.overlay_list.push_back(output_surface_plane);
237 } 237 }
238 238
239 // If we have any copy requests, we can't remove any quads for overlays, 239 // If we have any copy requests, we can't remove any quads for overlays,
240 // otherwise the framebuffer will be missing the overlay contents. 240 // otherwise the framebuffer will be missing the overlay contents.
241 if (root_render_pass->copy_requests.empty()) { 241 if (root_render_pass->copy_requests.empty()) {
242 overlay_processor_->ProcessForOverlays( 242 overlay_processor_->ProcessForOverlays(
243 resource_provider_, render_passes_in_draw_order, &frame.overlay_list, 243 resource_provider_, render_passes_in_draw_order, &frame.overlay_list,
244 &frame.root_damage_rect); 244 &frame.root_damage_rect);
245
246 // No need to render in case the damage rect is completely composited using
247 // overlays and dont have any copy requests.
248 if (frame.root_damage_rect.IsEmpty()) {
249 bool handle_copy_requests = false;
250 for (auto* pass : *render_passes_in_draw_order) {
251 if (!pass->copy_requests.empty()) {
252 handle_copy_requests = true;
253 break;
254 }
255 }
256
257 if (!handle_copy_requests) {
258 BindFramebufferToOutputSurface(&frame);
259 FinishDrawingFrame(&frame);
260 render_passes_in_draw_order->clear();
261 return;
262 }
263 }
245 } 264 }
246 265
247 for (size_t i = 0; i < render_passes_in_draw_order->size(); ++i) { 266 for (size_t i = 0; i < render_passes_in_draw_order->size(); ++i) {
248 RenderPass* pass = render_passes_in_draw_order->at(i); 267 RenderPass* pass = render_passes_in_draw_order->at(i);
249 DrawRenderPass(&frame, pass); 268 DrawRenderPass(&frame, pass);
250 269
251 for (ScopedPtrVector<CopyOutputRequest>::iterator it = 270 for (ScopedPtrVector<CopyOutputRequest>::iterator it =
252 pass->copy_requests.begin(); 271 pass->copy_requests.begin();
253 it != pass->copy_requests.end(); 272 it != pass->copy_requests.end();
254 ++it) { 273 ++it) {
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 ScopedResource* texture = render_pass_textures_.get(id); 556 ScopedResource* texture = render_pass_textures_.get(id);
538 return texture && texture->id(); 557 return texture && texture->id();
539 } 558 }
540 559
541 // static 560 // static
542 gfx::Size DirectRenderer::RenderPassTextureSize(const RenderPass* render_pass) { 561 gfx::Size DirectRenderer::RenderPassTextureSize(const RenderPass* render_pass) {
543 return render_pass->output_rect.size(); 562 return render_pass->output_rect.size();
544 } 563 }
545 564
546 } // namespace cc 565 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | cc/output/overlay_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698