Issue 1413753004: Allow inlining of native functions. Fix performance degradation (more investigation to follow).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413753004: Allow inlining of native functions. Fix performance degradation (more investigation to follow). (Closed)

Created:
5 years, 1 month ago by srdjan

Modified:
5 years, 1 month ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org, sra1

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Allow inlining of native functions. Fix performance degradation (more investigation to follow). BUG= Committed: https://github.com/dart-lang/sdk/commit/45650219b1ae6790549451a969af469149380deb

Patch Set 1 #

Patch Set 2 : d #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	runtime/vm/flow_graph_inliner.cc	View		2 chunks	+0 lines, -6 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

srdjan

Committed patchset #2 (id:20001) manually as 45650219b1ae6790549451a969af469149380deb (presubmit successful).

5 years, 1 month ago (2015-11-03 18:30:45 UTC) #3

Florian Schneider

5 years, 1 month ago (2015-11-03 18:34:18 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/1413753004/diff/20001/runtime/vm/flow_graph_i...
File runtime/vm/flow_graph_inliner.cc (left):

https://codereview.chromium.org/1413753004/diff/20001/runtime/vm/flow_graph_i...
runtime/vm/flow_graph_inliner.cc:1391: if (target.is_native()) {
Yes, we want to inline recognized methods. The flow graph builder bails out of
inlining non-recognized natives already in VisitNativeBodyNode.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages