Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1413753002: Added option --snapshot-after-run to enable an application snapshot to be taken after running the a… (Closed)

Created:
5 years, 2 months ago by siva
Modified:
5 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added option --snapshot-after-run to enable an application snapshot to be taken after running the application. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/040637a0e0d514fb5d071c51b5d21892e1277bb3

Patch Set 1 #

Total comments: 1

Patch Set 2 : code-review-change #

Total comments: 4

Patch Set 3 : code-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -28 lines) Patch
M runtime/bin/main.cc View 1 2 8 chunks +61 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
siva
5 years, 2 months ago (2015-10-16 21:12:15 UTC) #2
srdjan
lgtm https://chromiumcodereview.appspot.com/1413753002/diff/1/runtime/bin/main.cc File runtime/bin/main.cc (right): https://chromiumcodereview.appspot.com/1413753002/diff/1/runtime/bin/main.cc#newcode415 runtime/bin/main.cc:415: if (filename != NULL && strlen(filename) != 0) ...
5 years, 2 months ago (2015-10-16 21:26:56 UTC) #3
siva
Refactored code a bit to avoid code duplication while processing the two script snapshot options. ...
5 years, 2 months ago (2015-10-16 23:28:55 UTC) #4
srdjan
lgtm https://chromiumcodereview.appspot.com/1413753002/diff/20001/runtime/bin/main.cc File runtime/bin/main.cc (right): https://chromiumcodereview.appspot.com/1413753002/diff/20001/runtime/bin/main.cc#newcode386 runtime/bin/main.cc:386: bool *snapshot_option) { star close to type not ...
5 years, 2 months ago (2015-10-16 23:37:24 UTC) #5
siva
https://chromiumcodereview.appspot.com/1413753002/diff/20001/runtime/bin/main.cc File runtime/bin/main.cc (right): https://chromiumcodereview.appspot.com/1413753002/diff/20001/runtime/bin/main.cc#newcode386 runtime/bin/main.cc:386: bool *snapshot_option) { On 2015/10/16 23:37:24, srdjan wrote: > ...
5 years, 2 months ago (2015-10-16 23:49:52 UTC) #6
siva
5 years, 2 months ago (2015-10-17 00:10:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
040637a0e0d514fb5d071c51b5d21892e1277bb3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698