Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1413743003: Remove MissingTypeError to remove duplicate warnings (issue 24610) (Closed)

Created:
5 years, 2 months ago by Brian Wilkerson
Modified:
5 years, 2 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove MissingTypeError to remove duplicate warnings (issue 24610) R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/873d46cbbb9ab13f47a0e51cad1da35b7cc03066

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -24 lines) Patch
M pkg/analyzer/lib/src/task/strong/checker.dart View 3 chunks +2 lines, -10 lines 2 comments Download
M pkg/analyzer/lib/src/task/strong/info.dart View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 2 months ago (2015-10-16 22:06:44 UTC) #2
Leaf
lgtm https://codereview.chromium.org/1413743003/diff/1/pkg/analyzer/lib/src/task/strong/checker.dart File pkg/analyzer/lib/src/task/strong/checker.dart (right): https://codereview.chromium.org/1413743003/diff/1/pkg/analyzer/lib/src/task/strong/checker.dart#newcode919 pkg/analyzer/lib/src/task/strong/checker.dart:919: return expr.staticType ?? rules.provider.dynamicType; Is it a problem ...
5 years, 2 months ago (2015-10-16 22:21:12 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1413743003/diff/1/pkg/analyzer/lib/src/task/strong/checker.dart File pkg/analyzer/lib/src/task/strong/checker.dart (right): https://codereview.chromium.org/1413743003/diff/1/pkg/analyzer/lib/src/task/strong/checker.dart#newcode919 pkg/analyzer/lib/src/task/strong/checker.dart:919: return expr.staticType ?? rules.provider.dynamicType; We updated the SDK dependencies ...
5 years, 2 months ago (2015-10-17 14:53:13 UTC) #4
Brian Wilkerson
5 years, 2 months ago (2015-10-17 15:20:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
873d46cbbb9ab13f47a0e51cad1da35b7cc03066 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698