Issue 1413723014: Handle MJPEG HW Decode case in VideoCaptureImpl

Issue 1413723014: Handle MJPEG HW Decode case in VideoCaptureImpl (Closed)

Created:
5 years, 1 month ago by emircan

Modified:
5 years, 1 month ago

Reviewers:
mcasas, Pawel Osciak, hshi1

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Handle MJPEG HW Decode case in VideoCaptureImpl BUG=548693 TBR=mcasas@chromium.org Committed: https://crrev.com/438c5bb89001eda3d88071572272f089c2fdf2f3 Cr-Commit-Position: refs/heads/master@{#358177}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -10 lines)			Patch
	M	content/renderer/media/video_capture_impl.cc	View	1	2 chunks	+16 lines, -10 lines	1 comment	Download

Messages

Total messages: 11 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hshi1

LGTM - thanks I have verified that it fixes the renderer crash in apprtc.

5 years, 1 month ago (2015-11-05 21:49:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413723014/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413723014/20001

5 years, 1 month ago (2015-11-05 23:22:41 UTC) #7

commit-bot: I haz the power

Patchset 2 (id:??) landed as https://crrev.com/438c5bb89001eda3d88071572272f089c2fdf2f3 Cr-Commit-Position: refs/heads/master@{#358177}

5 years, 1 month ago (2015-11-05 23:38:07 UTC) #9

Pawel Osciak

5 years, 1 month ago (2015-11-05 23:49:26 UTC) #11

Message was sent while issue was closed.

https://codereview.chromium.org/1413723014/diff/20001/content/renderer/media/...
File content/renderer/media/video_capture_impl.cc (right):

https://codereview.chromium.org/1413723014/diff/20001/content/renderer/media/...
content/renderer/media/video_capture_impl.cc:393: DCHECK(frame);
nullptr is a valid return value from Wrap*() methods. We should use if() to
verify frame is not nullptr please.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages