Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1413723011: Fix accessor map transitions vs. Object.defineProperty (Closed)

Created:
5 years, 1 month ago by Jakob Kummerow
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix accessor map transitions vs. Object.defineProperty BUG=v8:4534 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/b4d46bc5a0bd6749091532282460534054d34f14 Cr-Commit-Position: refs/heads/master@{#31750}

Patch Set 1 #

Patch Set 2 : add testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M src/objects.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-4534.js View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
5 years, 1 month ago (2015-11-03 13:20:39 UTC) #1
Yang
On 2015/11/03 13:20:39, Jakob wrote: lgtm, but please add a test case that works without ...
5 years, 1 month ago (2015-11-03 13:55:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413723011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413723011/20001
5 years, 1 month ago (2015-11-03 14:04:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-03 14:41:24 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 14:42:02 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4d46bc5a0bd6749091532282460534054d34f14
Cr-Commit-Position: refs/heads/master@{#31750}

Powered by Google App Engine
This is Rietveld 408576698