Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1413723008: Revert of [es6] Fix Function and GeneratorFunction built-ins subclassing. (Closed)

Created:
5 years, 1 month ago by Igor Sheludko
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@subclass
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Fix Function and GeneratorFunction built-ins subclassing. (patchset #4 id:80001 of https://codereview.chromium.org/1428823002/ ) Reason for revert: Buildbot failures Original issue's description: > [es6] Fix Function and GeneratorFunction built-ins subclassing. > > BUG=v8:3101, v8:3330 > LOG=Y > > Committed: https://crrev.com/99e7f872d3d0a5fb799dcbafb05537cda491314a > Cr-Commit-Position: refs/heads/master@{#31708} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3101, v8:3330 Committed: https://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588 Cr-Commit-Position: refs/heads/master@{#31709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -137 lines) Patch
M src/bootstrapper.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/factory.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M src/js/generator.js View 1 chunk +3 lines, -5 lines 0 comments Download
M src/js/v8natives.js View 1 chunk +3 lines, -5 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +6 lines, -34 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +15 lines, -7 lines 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 2 chunks +0 lines, -60 lines 0 comments Download
M test/mjsunit/regress/regress-function-constructor-receiver.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Igor Sheludko
Created Revert of [es6] Fix Function and GeneratorFunction built-ins subclassing.
5 years, 1 month ago (2015-11-02 11:58:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413723008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413723008/1
5 years, 1 month ago (2015-11-02 11:58:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 11:59:03 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 11:59:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2210cc84de92a133580b4ef98965612ffe3f8588
Cr-Commit-Position: refs/heads/master@{#31709}

Powered by Google App Engine
This is Rietveld 408576698