Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1413723004: Revert of Make ImageBitmap Transferable (Closed)

Created:
5 years, 1 month ago by xidachen
Modified:
5 years, 1 month ago
CC:
jbroman, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), oilpan-reviews, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make ImageBitmap Transferable (patchset #9 id:160001 of https://codereview.chromium.org/1409243005/ ) Reason for revert: There are tests that are crashed: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan_Leak/14727/layout-test-results/results.html Original issue's description: > Make ImageBitmap Transferable > > Including a layout test that does 2 things: > 1. transfer an ImageBitmap to the worker and let worker transfer back to > main, the main thread exam the transfered-back ImageBitmap to make > sure the data is the same as the original ImageBitmap. > 2. When worker receives the ImageBitmap from main, worker calls > createImageBimmap() to create a new ImageBitmap and send it back to > main. > > BUG=532142 > > Committed: https://crrev.com/5d8ed50933226127fdc64744d86ab3d9b7d57276 > Cr-Commit-Position: refs/heads/master@{#356575} TBR=jochen@chromium.org,chrishtr@chromium.org,junov@chromium.org,haraken@chromium.org,sigbjornf@opera.com,yutak@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=532142 Committed: https://crrev.com/29f2c1d075f48f83978731e4209445dbd88e22c8 Cr-Commit-Position: refs/heads/master@{#356840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -340 lines) Patch
D third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageBitmap-transferable.html View 1 chunk +0 lines, -94 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageBitmap-transferable-expected.txt View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/resources/canvas-ImageBitmap-transferable.js View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 10 chunks +2 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 10 chunks +1 line, -60 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializationTag.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h View 4 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 7 chunks +3 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp View 7 chunks +18 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_methods.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 4 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/WebSerializedScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
xidachen
Created Revert of Make ImageBitmap Transferable
5 years, 1 month ago (2015-10-29 14:20:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413723004/1
5 years, 1 month ago (2015-10-29 14:20:43 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-10-29 14:20:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413723004/1
5 years, 1 month ago (2015-10-29 14:29:45 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-10-29 14:29:47 UTC) #8
jbroman
lgtm; this is a revert to fix a bug
5 years, 1 month ago (2015-10-29 14:44:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413723004/1
5 years, 1 month ago (2015-10-29 14:44:34 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 14:46:02 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/29f2c1d075f48f83978731e4209445dbd88e22c8 Cr-Commit-Position: refs/heads/master@{#356840}
5 years, 1 month ago (2015-10-29 14:47:19 UTC) #14
haraken
5 years, 1 month ago (2015-10-29 14:58:38 UTC) #15
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698