Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413713011: Revert "Extend the mDNS package with a native extension used on Mac OS" (Closed)

Created:
5 years, 1 month ago by Søren Gjesse
Modified:
5 years, 1 month ago
Reviewers:
ricow1
CC:
fletch+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/fletch.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Extend the mDNS package with a native extension used on Mac OS" This reverts commit 7b02aeda7e019a7daa08b2002be956150aaae4e2. TBR=ricow@google.com BUG= Committed: https://github.com/dart-lang/fletch/commit/6fd4f290758b3843ee1ba5a05b37276c73051e27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -670 lines) Patch
M .gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
M DEPS View 1 chunk +0 lines, -13 lines 0 comments Download
M build.ninja View 1 chunk +0 lines, -1 line 0 comments Download
M fletch.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/mdns/lib/mdns.dart View 2 chunks +78 lines, -32 lines 0 comments Download
D pkg/mdns/lib/native/libmdns_extension_lib.dylib.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D pkg/mdns/lib/native/libmdns_extension_lib.so.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/mdns/lib/src/constants.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/mdns/lib/src/lookup_resolver.dart View 2 chunks +6 lines, -9 lines 0 comments Download
D pkg/mdns/lib/src/native_extension_client.dart View 1 chunk +0 lines, -106 lines 0 comments Download
D pkg/mdns/lib/src/native_protocol_client.dart View 1 chunk +0 lines, -93 lines 0 comments Download
M pkg/mdns/test/decode_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/mdns/test/lookup_resolver_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/mdns/test/native_extension_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D src/pkg/mdns/README View 1 chunk +0 lines, -26 lines 0 comments Download
D src/pkg/mdns/copy_dylib.sh View 1 chunk +0 lines, -6 lines 0 comments Download
D src/pkg/mdns/mdns.gyp View 1 chunk +0 lines, -43 lines 0 comments Download
D src/pkg/mdns/mdns_extension.h View 1 chunk +0 lines, -20 lines 0 comments Download
D src/pkg/mdns/mdns_extension.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D src/pkg/mdns/mdns_extension_linux.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D src/pkg/mdns/mdns_extension_macos.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D src/pkg/mdns/upload_dylib.sh View 1 chunk +0 lines, -14 lines 0 comments Download
M tests/fletch_tests/all_tests.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/mdns_tests/mdns_tests.dart View 1 chunk +5 lines, -11 lines 0 comments Download
M tools/testing/dart/fletch_warnings_suite.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
5 years, 1 month ago (2015-11-02 10:37:33 UTC) #1
Søren Gjesse
Committed patchset #1 (id:1) manually as 6fd4f290758b3843ee1ba5a05b37276c73051e27 (presubmit successful).
5 years, 1 month ago (2015-11-02 10:37:44 UTC) #2
ricow1
5 years, 1 month ago (2015-11-02 10:37:54 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698