Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1615)

Unified Diff: chrome/browser/profiles/profile_shortcut_manager_win.h

Issue 14137032: Create profile .ico file on profile creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rework Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_shortcut_manager_win.h
diff --git a/chrome/browser/profiles/profile_shortcut_manager_win.h b/chrome/browser/profiles/profile_shortcut_manager_win.h
index 631a71303e6cbef73a4e7c411211ee0010c073ab..983498502bf7e3ffc93aebc36ea9b656e1363430 100644
--- a/chrome/browser/profiles/profile_shortcut_manager_win.h
+++ b/chrome/browser/profiles/profile_shortcut_manager_win.h
@@ -13,8 +13,8 @@ class BrowserDistribution;
namespace profiles {
namespace internal {
-// Name of the badged icon file generated for a given profile.
-extern const char kProfileIconFileName[];
+// Returns the full path to the profile icon file.
+base::FilePath GetProfileIconPath(const base::FilePath& profile_path);
// Returns the default shortcut filename for the given profile name,
// given |distribution|. Returns a filename appropriate for a
@@ -31,10 +31,13 @@ string16 CreateProfileShortcutFlags(const base::FilePath& profile_path);
class ProfileShortcutManagerWin : public ProfileShortcutManager,
public ProfileInfoCacheObserver {
public:
- // Specifies whether a new shortcut should be created if none exist.
+ // Specifies whether only the existing shortcuts should be updated, a new
+ // shortcut should be created if none exist, or only the icon for this profile
+ // should be created in the profile directory.
enum CreateOrUpdateMode {
UPDATE_EXISTING_ONLY,
CREATE_WHEN_NONE_FOUND,
+ CREATE_ICON_ONLY,
};
// Specifies whether non-profile shortcuts should be updated.
enum NonProfileShortcutAction {
@@ -46,6 +49,9 @@ class ProfileShortcutManagerWin : public ProfileShortcutManager,
virtual ~ProfileShortcutManagerWin();
// ProfileShortcutManager implementation:
+ virtual void CreateProfileIcon(
+ const base::FilePath& profile_path,
+ const base::Closure& callback) OVERRIDE;
virtual void CreateProfileShortcut(
const base::FilePath& profile_path) OVERRIDE;
virtual void RemoveProfileShortcuts(
@@ -70,10 +76,13 @@ class ProfileShortcutManagerWin : public ProfileShortcutManager,
// Must only be called when the number profiles is 2.
base::FilePath GetOtherProfilePath(const base::FilePath& profile_path);
+ void UpdateProfileIcon(const base::FilePath& profile_path);
Alexei Svitkine (slow) 2013/06/10 17:44:52 Add a comment.
calamity 2013/06/13 06:26:03 Oops, this isn't needed anymore. Removed.
+
void CreateOrUpdateShortcutsForProfileAtPath(
const base::FilePath& profile_path,
CreateOrUpdateMode create_mode,
- NonProfileShortcutAction action);
+ NonProfileShortcutAction action,
+ const base::Closure& callback);
ProfileManager* profile_manager_;

Powered by Google App Engine
This is Rietveld 408576698