Create profile .ico file on profile creation

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
@@ skipping 715 matching lines @@
   } else {
     last_session_exit_type_ =
         SessionTypePrefValueToExitType(exit_type_pref_value);
   }
   // Mark the session as open.
   prefs_->SetString(prefs::kSessionExitType, kPrefExitTypeCrashed);
   // Force this to true in case we fallback and use it.
   // TODO(sky): remove this in a couple of releases (m28ish).
   prefs_->SetBoolean(prefs::kSessionExitedCleanly, true);
 
+#if defined(OS_WIN)
+  if (!prefs_->GetBoolean(prefs::kProfileIconCreated)) {
+  // Ensure the profile's icon file has been created.

[Alexei Svitkine (slow), 2013/05/24 14:43:51]

Nit: Indent 2 more.

[calamity, 2013/05/31 04:07:27]

Done.

+    ProfileShortcutManager* profile_shortcut_manager =
+        g_browser_process->profile_manager()->profile_shortcut_manager();
+    if (profile_shortcut_manager) {
+      profile_shortcut_manager->CreateProfileIcon(GetPath());
+      prefs_->SetBoolean(prefs::kProfileIconCreated, true);

[Alexei Svitkine (slow), 2013/05/24 14:43:51]

I would still like to have this pref set only after icon creation succeeded.

I think both checking the pref and updating it can be moved to
CreateProfileIcon(), that way the public interface of the function can remain
simple. Then, setting the pref on success can be done in a private function on
ProfileShortcutManagerWin that gets passed as the 2nd callback param to
PostTaskAndReplyWithResult(), based on the result of the other op.

[calamity, 2013/05/31 04:07:27]

I'm a little hesitant to do this if the name is going to be CreateProfileIcon. I
think it would be confusing to call this and not have it actually create
anything because of a the condition in its implementation.
ProfileShortcutManager::HasProfileShortcuts already has a callback in its params
and I think it might be better to go with that. WDYT?

[Alexei Svitkine (slow), 2013/05/31 13:48:38]

I'm okay with the having the callback exposed too.

[calamity, 2013/06/04 01:24:57]

Done.

+    }
+  }
+#endif
+
   ProfileDependencyManager::GetInstance()->CreateProfileServices(this, false);
 
   DCHECK(!net_pref_observer_);
   net_pref_observer_.reset(new NetPrefObserver(
       prefs_.get(),
       prerender::PrerenderManagerFactory::GetForProfile(this),
       predictor_));
 
   ChromeVersionService::OnProfileLoaded(prefs_.get(), IsNewProfile());
   DoFinalInit();
@@ skipping 389 matching lines @@
                                      base::FilePath* cache_path,
                                      int* max_size) {
   DCHECK(cache_path);
   DCHECK(max_size);
   base::FilePath path(prefs_->GetFilePath(prefs::kDiskCacheDir));
   if (!path.empty())
     *cache_path = path;
   *max_size = is_media_context ? prefs_->GetInteger(prefs::kMediaCacheSize) :
                                  prefs_->GetInteger(prefs::kDiskCacheSize);
 }