Create profile .ico file on profile creation

chrome/browser/profiles/profile_shortcut_manager_win.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_SHORTCUT_MANAGER_WIN_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_SHORTCUT_MANAGER_WIN_H_
 
 #include "chrome/browser/profiles/profile_shortcut_manager.h"
 
 class BrowserDistribution;
 
 // Internal free-standing functions that are exported here for testing.
 namespace profiles {
 namespace internal {
 
 // Name of the badged icon file generated for a given profile.
 extern const char kProfileIconFileName[];
 
+// Returns the full path to the profile icon file.
+base::FilePath GetProfileIconPath(const base::FilePath& profile_path);
+
 // Returns the default shortcut filename for the given profile name,
 // given |distribution|. Returns a filename appropriate for a
 // single-user installation if |profile_name| is empty.
 string16 GetShortcutFilenameForProfile(const string16& profile_name,
                                        BrowserDistribution* distribution);
 
 // Returns the command-line flags to launch Chrome with the given profile.
 string16 CreateProfileShortcutFlags(const base::FilePath& profile_path);
 
 }  // namespace internal
 }  // namespace profiles
 
 class ProfileShortcutManagerWin : public ProfileShortcutManager,
                                   public ProfileInfoCacheObserver {
  public:
-  // Specifies whether a new shortcut should be created if none exist.
+  // Specifies whether the only existing shortcuts should be updated, a new

[gab, 2013/05/07 12:38:39]

s/the only/only the

[calamity, 2013/05/08 08:15:42]

Done.

+  // shortcut should be created if none exist, or only the icon for this profile
+  // should be updated.

[gab, 2013/05/07 12:38:39]

s/updated./created in the profile directory.

[calamity, 2013/05/08 08:15:42]

Done.

   enum CreateOrUpdateMode {
     UPDATE_EXISTING_ONLY,
     CREATE_WHEN_NONE_FOUND,
+    CREATE_ICON_ONLY,
   };
   // Specifies whether non-profile shortcuts should be updated.
   enum NonProfileShortcutAction {
     IGNORE_NON_PROFILE_SHORTCUTS,
     UPDATE_NON_PROFILE_SHORTCUTS,
   };
 
   explicit ProfileShortcutManagerWin(ProfileManager* manager);
   virtual ~ProfileShortcutManagerWin();
 
   // ProfileShortcutManager implementation:
+  virtual void CreateProfileIcon(
+      const base::FilePath& profile_path) OVERRIDE;

[Alexei Svitkine (slow), 2013/05/03 17:20:47]

Please add a unit test for this. (i.e. create a profile, ensure that an icon got
created, then delete it and call this function and ensure it got created again.)

[calamity, 2013/05/08 08:15:42]

Done.

   virtual void CreateProfileShortcut(
       const base::FilePath& profile_path) OVERRIDE;
   virtual void RemoveProfileShortcuts(
       const base::FilePath& profile_path) OVERRIDE;
   virtual void HasProfileShortcuts(
       const base::FilePath& profile_path,
       const base::Callback<void(bool)>& callback) OVERRIDE;
 
   // ProfileInfoCacheObserver implementation:
   virtual void OnProfileAdded(const base::FilePath& profile_path) OVERRIDE;
@@ skipping 15 matching lines @@
       const base::FilePath& profile_path,
       CreateOrUpdateMode create_mode,
       NonProfileShortcutAction action);
 
   ProfileManager* profile_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileShortcutManagerWin);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_SHORTCUT_MANAGER_WIN_H_