Create profile .ico file on profile creation

chrome/browser/profiles/profile.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile.h"
 
 #include <string>
 
 #include "base/prefs/pref_service.h"
 #include "build/build_config.h"
@@ skipping 86 matching lines @@
       prefs::kDefaultZoomLevel,
       0.0,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDictionaryPref(
       prefs::kPerHostZoomLevels,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterStringPref(
       prefs::kDefaultApps,
       "install",
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+  registry->RegisterIntegerPref(
+      prefs::kProfileIconVersion,
+      0,

[gab, 2013/06/18 15:36:58]

Why is this an integer? As it is right now it is used as boolean (i.e. only
checked on profile creation).

Having it be an integer only feels right if there is code to update the icon if
kCurrentProfileIconVersion is higher than prefs::kProfileIconVersion when Chrome
starts or something (see my comment on ProfileShortcutManagerWin::Observe).

[Alexei Svitkine (slow), 2013/06/18 15:44:32]

See previous discussion. Having it an integer is more future proof, if we later
need to update existing icons for some reason (e.g. Chrome's icon changes)
rather than adding a whole new pref at that point.

[gab, 2013/06/18 15:51:38]

Right, makes sense, I think it's pretty easy to add such update code now though
(see my comment on ProfileShortcutManagerWin::Observe) which would prevent
somehow from assuming upping kCurrentProfileIconVersion is sufficient when it is
not.

+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
 #if defined(OS_CHROMEOS)
   // TODO(dilmah): For OS_CHROMEOS we maintain kApplicationLocale in both
   // local state and user's profile.  For other platforms we maintain
   // kApplicationLocale only in local state.
   // In the future we may want to maintain kApplicationLocale
   // in user's profile for other platforms as well.
   registry->RegisterStringPref(prefs::kApplicationLocale,
                                std::string(),
                                user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
   registry->RegisterStringPref(
@@ skipping 60 matching lines @@
 
 void Profile::MaybeSendDestroyedNotification() {
   if (!sent_destroyed_notification_) {
     sent_destroyed_notification_ = true;
     content::NotificationService::current()->Notify(
         chrome::NOTIFICATION_PROFILE_DESTROYED,
         content::Source<Profile>(this),
         content::NotificationService::NoDetails());
   }
 }